Replace all classNameWithoutNamespace() calls with entityName()

Done via

```
find . \( -path './DerivedData' -o -path './.git' -o -path './vendor' \) \
  -prune -o -type f -name "*.swift" \
  -exec sed -i '' -E 's/forEntityName: ([A-Za-z_][A-Za-z0-9_]*)\.classNameWithoutNamespaces\(\)/forEntityName: \1.entityName()/g' {} +
```

The goal is to have a single way to get the entity name so we can adapt
it to the new WordPressData setup in one go.

Author: mokagio

Tests/KeystoneTests/Tests/Features/Aztec/MediaProgressCoordinatorTests.swift

@@ -9,7 +9,7 @@ class MediaProgressCoordinatorTests: CoreDataTestCase {
     var mediaProgressCoordinator: MediaProgressCoordinator!
 
     fileprivate func makeTestMedia() -> Media {
-        return NSEntityDescription.insertNewObject(forEntityName: Media.classNameWithoutNamespaces(), into: mainContext) as! Media
+        return NSEntityDescription.insertNewObject(forEntityName: Media.entityName(), into: mainContext) as! Media
     }
 
     override func setUp() {

Tests/KeystoneTests/Tests/Models/MediaTests.swift

@@ -5,7 +5,7 @@ import XCTest
 class MediaTests: CoreDataTestCase {
 
     fileprivate func newTestMedia() -> Media {
-        return NSEntityDescription.insertNewObject(forEntityName: Media.classNameWithoutNamespaces(), into: mainContext) as! Media
+        return NSEntityDescription.insertNewObject(forEntityName: Media.entityName(), into: mainContext) as! Media
     }
 
     func testThatAbsoluteURLsWork() {

Tests/KeystoneTests/Tests/Services/FollowCommentsServiceTests.swift

@@ -153,7 +153,7 @@ class FollowCommentsServiceTests: CoreDataTestCase {
     // MARK: - Helpers
 
        func seedReaderListTopic() -> ReaderListTopic {
-           let topic = NSEntityDescription.insertNewObject(forEntityName: ReaderListTopic.classNameWithoutNamespaces(), into: mainContext) as! ReaderListTopic
+           let topic = NSEntityDescription.insertNewObject(forEntityName: ReaderListTopic.entityName(), into: mainContext) as! ReaderListTopic
            topic.path = "/list/topic1"
            topic.title = "topic1"
            topic.type = ReaderListTopic.TopicType
@@ -168,7 +168,7 @@ class FollowCommentsServiceTests: CoreDataTestCase {
        }
 
        func seedReaderTeamTopic() -> ReaderTeamTopic {
-           let topic = NSEntityDescription.insertNewObject(forEntityName: ReaderTeamTopic.classNameWithoutNamespaces(), into: mainContext) as! ReaderTeamTopic
+           let topic = NSEntityDescription.insertNewObject(forEntityName: ReaderTeamTopic.entityName(), into: mainContext) as! ReaderTeamTopic
             topic.path = "/a8c/topic2"
             topic.title = "topic2"
             topic.type = ReaderTeamTopic.TopicType
@@ -183,7 +183,7 @@ class FollowCommentsServiceTests: CoreDataTestCase {
        }
 
        func seedReaderPostForTopic(_ topic: ReaderAbstractTopic) -> ReaderPost {
-           let post = NSEntityDescription.insertNewObject(forEntityName: ReaderPost.classNameWithoutNamespaces(), into: mainContext) as! ReaderPost
+           let post = NSEntityDescription.insertNewObject(forEntityName: ReaderPost.entityName(), into: mainContext) as! ReaderPost
            post.siteID = siteID
            post.postID = postID
            post.topic = topic
@@ -198,7 +198,7 @@ class FollowCommentsServiceTests: CoreDataTestCase {
        }
 
        func seedBlog(isWPForTeams: Bool) {
-           let blog = NSEntityDescription.insertNewObject(forEntityName: Blog.classNameWithoutNamespaces(), into: mainContext) as! Blog
+           let blog = NSEntityDescription.insertNewObject(forEntityName: Blog.entityName(), into: mainContext) as! Blog
            blog.dotComID = siteID
            blog.xmlrpc = "http://test.blog/xmlrpc.php"
            blog.url = "http://test.blog/"

Tests/KeystoneTests/Tests/Services/ReaderTopicServiceTest.swift

@@ -21,17 +21,17 @@ final class ReaderTopicSwiftTest: CoreDataTestCase {
     // MARK: - Config / Helpers
 
     func seedTopics() {
-        let topic1 = NSEntityDescription.insertNewObject(forEntityName: ReaderListTopic.classNameWithoutNamespaces(), into: mainContext) as! ReaderListTopic
+        let topic1 = NSEntityDescription.insertNewObject(forEntityName: ReaderListTopic.entityName(), into: mainContext) as! ReaderListTopic
         topic1.path = "/list/topic1"
         topic1.title = "topic1"
         topic1.type = ReaderListTopic.TopicType
 
-        let topic2 = NSEntityDescription.insertNewObject(forEntityName: ReaderTagTopic.classNameWithoutNamespaces(), into: mainContext) as! ReaderTagTopic
+        let topic2 = NSEntityDescription.insertNewObject(forEntityName: ReaderTagTopic.entityName(), into: mainContext) as! ReaderTagTopic
         topic2.path = "/tags/topic2"
         topic2.title = "topic2"
         topic2.type = ReaderTagTopic.TopicType
 
-        let topic3 = NSEntityDescription.insertNewObject(forEntityName: ReaderTagTopic.classNameWithoutNamespaces(), into: mainContext) as! ReaderTagTopic
+        let topic3 = NSEntityDescription.insertNewObject(forEntityName: ReaderTagTopic.entityName(), into: mainContext) as! ReaderTagTopic
         topic3.path = "/list/topic3"
         topic3.title = "topic3"
         topic3.type = ReaderTagTopic.TopicType
@@ -49,19 +49,19 @@ final class ReaderTopicSwiftTest: CoreDataTestCase {
     }
 
     func seedPostsForTopic(_ topic: ReaderAbstractTopic) {
-        let post1 = NSEntityDescription.insertNewObject(forEntityName: ReaderPost.classNameWithoutNamespaces(), into: mainContext) as! ReaderPost
+        let post1 = NSEntityDescription.insertNewObject(forEntityName: ReaderPost.entityName(), into: mainContext) as! ReaderPost
         post1.postID = NSNumber(value: 1)
         post1.postTitle = "post1"
         post1.content = "post1"
         post1.topic = topic
 
-        let post2 = NSEntityDescription.insertNewObject(forEntityName: ReaderPost.classNameWithoutNamespaces(), into: mainContext) as! ReaderPost
+        let post2 = NSEntityDescription.insertNewObject(forEntityName: ReaderPost.entityName(), into: mainContext) as! ReaderPost
         post2.postID = NSNumber(value: 2)
         post2.postTitle = "post2"
         post2.content = "post2"
         post2.topic = topic
 
-        let post3 = NSEntityDescription.insertNewObject(forEntityName: ReaderPost.classNameWithoutNamespaces(), into: mainContext) as! ReaderPost
+        let post3 = NSEntityDescription.insertNewObject(forEntityName: ReaderPost.entityName(), into: mainContext) as! ReaderPost
         post3.postID = NSNumber(value: 3)
         post3.postTitle = "post3"
         post3.content = "post3"
@@ -356,7 +356,7 @@ final class ReaderTopicSwiftTest: CoreDataTestCase {
     */
     func testPostsDeletedWhenTopicDeleted() {
         // setup
-        let topic = NSEntityDescription.insertNewObject(forEntityName: ReaderListTopic.classNameWithoutNamespaces(), into: mainContext) as! ReaderListTopic
+        let topic = NSEntityDescription.insertNewObject(forEntityName: ReaderListTopic.entityName(), into: mainContext) as! ReaderListTopic
         topic.path = "/list/topic"
         topic.title = "topic"
         topic.type = ReaderListTopic.TopicType

WordPress/Classes/Models/PublicizeConnection+Creation.swift

@@ -11,7 +11,7 @@ extension PublicizeConnection {
     ///
     static func createOrReplace(from remoteConnection: RemotePublicizeConnection, in context: NSManagedObjectContext) -> PublicizeConnection {
         let pubConnection = findPublicizeConnection(byID: remoteConnection.connectionID, in: context)
-            ?? NSEntityDescription.insertNewObject(forEntityName: PublicizeConnection.classNameWithoutNamespaces(),
+            ?? NSEntityDescription.insertNewObject(forEntityName: PublicizeConnection.entityName(),
                 into: context) as! PublicizeConnection
 
         pubConnection.connectionID = remoteConnection.connectionID

WordPress/Classes/Services/ReaderTopicService+Subscriptions.swift

@@ -30,12 +30,12 @@ extension ReaderTopicService {
         }
 
         if siteTopic.postSubscription == nil {
-            siteTopic.postSubscription = NSEntityDescription.insertNewObject(forEntityName: ReaderSiteInfoSubscriptionPost.classNameWithoutNamespaces(),
+            siteTopic.postSubscription = NSEntityDescription.insertNewObject(forEntityName: ReaderSiteInfoSubscriptionPost.entityName(),
                                                                              into: context) as? ReaderSiteInfoSubscriptionPost
         }
 
         if siteTopic.emailSubscription == nil {
-            siteTopic.emailSubscription = NSEntityDescription.insertNewObject(forEntityName: ReaderSiteInfoSubscriptionEmail.classNameWithoutNamespaces(),
+            siteTopic.emailSubscription = NSEntityDescription.insertNewObject(forEntityName: ReaderSiteInfoSubscriptionEmail.entityName(),
                                                                               into: context) as? ReaderSiteInfoSubscriptionEmail
         }
 

WordPress/Classes/Services/SharingService.swift

@@ -323,7 +323,7 @@ import WordPressKit
     private func createOrReplaceFromRemotePublicizeService(_ remoteService: RemotePublicizeService, in context: NSManagedObjectContext) -> PublicizeService {
         var pubService = try? PublicizeService.lookupPublicizeServiceNamed(remoteService.serviceID, in: context)
         if pubService == nil {
-            pubService = NSEntityDescription.insertNewObject(forEntityName: PublicizeService.classNameWithoutNamespaces(),
+            pubService = NSEntityDescription.insertNewObject(forEntityName: PublicizeService.entityName(),
                 into: context) as? PublicizeService
         }
         pubService?.connectURL = remoteService.connectURL
@@ -451,7 +451,7 @@ import WordPressKit
     private func createOrReplaceFromRemoteSharingButton(_ remoteButton: RemoteSharingButton, blog: Blog, in context: NSManagedObjectContext) -> SharingButton {
         var shareButton = try? SharingButton.lookupSharingButton(byID: remoteButton.buttonID, for: blog, in: context)
         if shareButton == nil {
-            shareButton = NSEntityDescription.insertNewObject(forEntityName: SharingButton.classNameWithoutNamespaces(),
+            shareButton = NSEntityDescription.insertNewObject(forEntityName: SharingButton.entityName(),
                 into: context) as? SharingButton
         }