Skip to content

Commit f4c576c

Browse files
committed
Use the same key for the Reader build step across pipelines
See how https://buildkite.com/automattic/wordpress-ios/builds/27417/steps?jid=01964b59-300d-46d2-bf40-33558caa03fa failed because the pipeline used `reader_asc_build` instead of `build_asc_reader`. I decided to consolidate to `build_asc_reader` because of the information hierarchy: build > build for ASC > build for ASC, the Reader app. When we'll get to split build from upload for the other apps, we'll be able to have auto-complete friendly keys, su as `build_asc_wordpress` or `build_firebase_jetpack`.
1 parent 8618b81 commit f4c576c

File tree

1 file changed

+2
-2
lines changed

1 file changed

+2
-2
lines changed

.buildkite/reader-testflight.yml

+2-2
Original file line numberDiff line numberDiff line change
@@ -4,7 +4,7 @@
44
steps:
55
- label: ":eyeglasses: :xcode: Reader App Store Connect Build"
66
command: .buildkite/commands/release-build-reader.sh
7-
key: reader_asc_build
7+
key: build_asc_reader
88
plugins: [$CI_TOOLKIT_PLUGIN]
99
agents:
1010
queue: mac
@@ -17,7 +17,7 @@ steps:
1717
- slack: "#build-and-ship"
1818

1919
- label: ":eyeglasses: :testflight: Reader App Store Connect Upload"
20-
depends_on: reader_asc_build
20+
depends_on: build_asc_reader
2121
command: .buildkite/commands/release-upload-reader.sh
2222
plugins: [$CI_TOOLKIT_PLUGIN]
2323
agents:

0 commit comments

Comments
 (0)