Skip to content

Commit bb58f91

Browse files
authored
Merge pull request #1203 from wowsims/feature/p3-updates
Update Ret, FDK, UHDK and Hunter to P3 sets by default
2 parents 2a71576 + 0285186 commit bb58f91

38 files changed

+7567
-9339
lines changed

sim/death_knight/frost/TestFrostMasterfrost.results

Lines changed: 1186 additions & 1169 deletions
Large diffs are not rendered by default.

sim/death_knight/frost/TestFrostTwoHand.results

Lines changed: 1185 additions & 1167 deletions
Large diffs are not rendered by default.

sim/death_knight/frost/frost_test.go

Lines changed: 59 additions & 48 deletions
Original file line numberDiff line numberDiff line change
@@ -19,17 +19,38 @@ func TestFrostMasterfrost(t *testing.T) {
1919
Class: proto.Class_ClassDeathKnight,
2020
Race: proto.Race_RaceTroll,
2121

22-
GearSet: core.GetGearSet("../../../ui/death_knight/frost/gear_sets", "p2.masterfrost"),
22+
GearSet: core.GetGearSet("../../../ui/death_knight/frost/gear_sets", "p3.masterfrost"),
23+
2324
Talents: DefaultTalents,
2425
OtherTalentSets: OtherTalentSets,
25-
Glyphs: FrostDefaultGlyphs,
26-
Consumables: FullConsumesSpec,
27-
SpecOptions: core.SpecOptionsCombo{Label: "Basic", SpecOptions: PlayerOptionsFrost},
28-
Rotation: core.GetAplRotation("../../../ui/death_knight/frost/apls", "masterfrost"),
29-
Profession1: proto.Profession_Engineering,
30-
Profession2: proto.Profession_Blacksmithing,
31-
32-
ItemFilter: ItemFilterMasterfrost,
26+
27+
Glyphs: FrostDefaultGlyphs,
28+
29+
Consumables: FullConsumesSpec,
30+
31+
SpecOptions: core.SpecOptionsCombo{Label: "Basic", SpecOptions: PlayerOptionsFrost},
32+
33+
Rotation: core.GetAplRotation("../../../ui/death_knight/frost/apls", "masterfrost"),
34+
35+
Profession1: proto.Profession_Engineering,
36+
Profession2: proto.Profession_Herbalism,
37+
38+
ItemFilter: core.ItemFilter{
39+
ArmorType: proto.ArmorType_ArmorTypePlate,
40+
41+
HandTypes: []proto.HandType{
42+
proto.HandType_HandTypeMainHand,
43+
proto.HandType_HandTypeOffHand,
44+
proto.HandType_HandTypeOneHand,
45+
},
46+
47+
WeaponTypes: []proto.WeaponType{
48+
proto.WeaponType_WeaponTypeAxe,
49+
proto.WeaponType_WeaponTypeSword,
50+
proto.WeaponType_WeaponTypeMace,
51+
},
52+
RangedWeaponTypes: []proto.RangedWeaponType{},
53+
},
3354
},
3455
}))
3556
}
@@ -40,17 +61,37 @@ func TestFrostTwoHand(t *testing.T) {
4061
Class: proto.Class_ClassDeathKnight,
4162
Race: proto.Race_RaceTroll,
4263

43-
GearSet: core.GetGearSet("../../../ui/death_knight/frost/gear_sets", "p2.2h-obliterate"),
64+
GearSet: core.GetGearSet("../../../ui/death_knight/frost/gear_sets", "p3.2h-obliterate"),
65+
4466
Talents: DefaultTalents,
4567
OtherTalentSets: OtherTalentSets,
46-
Glyphs: FrostDefaultGlyphs,
47-
Consumables: FullConsumesSpec,
48-
SpecOptions: core.SpecOptionsCombo{Label: "Basic", SpecOptions: PlayerOptionsFrost},
49-
Rotation: core.GetAplRotation("../../../ui/death_knight/frost/apls", "obliterate"),
50-
Profession1: proto.Profession_Engineering,
51-
Profession2: proto.Profession_Blacksmithing,
52-
53-
ItemFilter: ItemFilterTwoHand,
68+
69+
Glyphs: FrostDefaultGlyphs,
70+
71+
Consumables: FullConsumesSpec,
72+
73+
SpecOptions: core.SpecOptionsCombo{Label: "Basic", SpecOptions: PlayerOptionsFrost},
74+
75+
Rotation: core.GetAplRotation("../../../ui/death_knight/frost/apls", "obliterate"),
76+
77+
Profession1: proto.Profession_Engineering,
78+
Profession2: proto.Profession_Herbalism,
79+
80+
ItemFilter: core.ItemFilter{
81+
ArmorType: proto.ArmorType_ArmorTypePlate,
82+
83+
HandTypes: []proto.HandType{
84+
proto.HandType_HandTypeTwoHand,
85+
},
86+
87+
WeaponTypes: []proto.WeaponType{
88+
proto.WeaponType_WeaponTypeAxe,
89+
proto.WeaponType_WeaponTypeMace,
90+
proto.WeaponType_WeaponTypePolearm,
91+
proto.WeaponType_WeaponTypeSword,
92+
},
93+
RangedWeaponTypes: []proto.RangedWeaponType{},
94+
},
5495
},
5596
}))
5697
}
@@ -84,33 +125,3 @@ var FullConsumesSpec = &proto.ConsumesSpec{
84125
PotId: 76095, // Potion of Mogu Power
85126
PrepotId: 76095, // Potion of Mogu Power
86127
}
87-
88-
var ItemFilterMasterfrost = core.ItemFilter{
89-
ArmorType: proto.ArmorType_ArmorTypePlate,
90-
91-
HandTypes: []proto.HandType{
92-
proto.HandType_HandTypeMainHand,
93-
proto.HandType_HandTypeOffHand,
94-
proto.HandType_HandTypeOneHand,
95-
},
96-
WeaponTypes: []proto.WeaponType{
97-
proto.WeaponType_WeaponTypeAxe,
98-
proto.WeaponType_WeaponTypeSword,
99-
proto.WeaponType_WeaponTypeMace,
100-
},
101-
RangedWeaponTypes: []proto.RangedWeaponType{},
102-
}
103-
104-
var ItemFilterTwoHand = core.ItemFilter{
105-
ArmorType: proto.ArmorType_ArmorTypePlate,
106-
107-
HandTypes: []proto.HandType{
108-
proto.HandType_HandTypeTwoHand,
109-
},
110-
WeaponTypes: []proto.WeaponType{
111-
proto.WeaponType_WeaponTypeAxe,
112-
proto.WeaponType_WeaponTypeSword,
113-
proto.WeaponType_WeaponTypeMace,
114-
},
115-
RangedWeaponTypes: []proto.RangedWeaponType{},
116-
}

0 commit comments

Comments
 (0)