refactor and addressing PR review comments

Author: asoorm

protographic/src/operation-to-proto.ts

@@ -268,10 +268,12 @@ class OperationsToProtoVisitor {
     // This ensures exact matching between GraphQL operation names and RPC method names
     // PascalCase: starts with uppercase, contains at least one lowercase letter
     if (!/^[A-Z](?=.*[a-z])[a-zA-Z0-9]*$/.test(operationName)) {
+      const suggestedName = upperFirst(camelCase(operationName));
       throw new Error(
         `Operation name "${operationName}" must be in PascalCase ` +
           `(start with uppercase letter, followed by mixed-case letters/numbers). ` +
           `Examples: GetUser, CreatePost, OnMessageAdded. ` +
+          `Suggested name: "${suggestedName}". ` +
           `This ensures the RPC method name exactly matches the GraphQL operation name.`,
       );
     }

router-tests/connectrpc/README.md

@@ -82,15 +82,12 @@ func TestConnectRPC_ServerLifecycle_StartStopReload(t *testing.T) {
 func TestConnectRPC_ServerLifecycle_ErrorScenarios(t *testing.T) {
 	t.Parallel()
 
-	t.Run("start fails with invalid proto directory", func(t *testing.T) {
-		server, err := connectrpc.NewServer(connectrpc.ServerConfig{
+	t.Run("NewServer fails with invalid proto directory", func(t *testing.T) {
+		_, err := connectrpc.NewServer(connectrpc.ServerConfig{
 			ServicesDir:     "/nonexistent/path",
 			GraphQLEndpoint: "http://localhost:4000/graphql",
 			Logger:          zap.NewNop(),
 		})
-		require.NoError(t, err)
-
-		err = server.Start()
 		assert.Error(t, err)
 		assert.Contains(t, err.Error(), "failed to discover services")
 	})
@@ -147,19 +144,22 @@ func TestConnectRPC_Server_GetServiceInfo(t *testing.T) {
 	t.Run("returns consistent service count and names", func(t *testing.T) {
 		ts := NewTestConnectRPCServer(t, ConnectRPCServerOptions{})
 
-		// Before start
-		assert.Equal(t, 0, ts.GetServiceCount())
-		assert.Empty(t, ts.GetServiceNames())
-
-		err := ts.Start()
-		require.NoError(t, err)
-
-		// After start - verify count and names are consistent
+		// Services are loaded during NewServer, so they should be available immediately
 		count := ts.GetServiceCount()
 		names := ts.GetServiceNames()
 
-		assert.GreaterOrEqual(t, count, 1, "should have at least one service")
+		assert.GreaterOrEqual(t, count, 1, "should have at least one service after NewServer")
 		assert.Len(t, names, count, "service names length should match count")
 		assert.NotEmpty(t, names, "service names should not be empty")
+
+		err := ts.Start()
+		require.NoError(t, err)
+
+		// After start - verify count and names remain consistent
+		countAfterStart := ts.GetServiceCount()
+		namesAfterStart := ts.GetServiceNames()
+		
+		assert.Equal(t, count, countAfterStart, "service count should remain the same after Start")
+		assert.ElementsMatch(t, names, namesAfterStart, "service names should remain the same after Start")
 	})
 }

router-tests/connectrpc/connectrpc_server_lifecycle_test.go

@@ -2,64 +2,32 @@
 
 This directory contains Protocol Buffer definitions and GraphQL operations for ConnectRPC integration tests.
 
-## Directory Structure
+## Writing New Tests
 
-```
-router-tests/testdata/connectrpc/
-├── services/             # Proto service definitions and GraphQL operations
-│   └── employee.v1/      # Employee service v1
-│       ├── service.proto                              # Proto service definition
-│       ├── QueryGetEmployeeById.graphql              # GraphQL query operation
-│       ├── QueryGetEmployeeByPets.graphql            # GraphQL query operation
-│       ├── QueryGetEmployees.graphql                 # GraphQL query operation
-│       ├── QueryGetEmployeesByPetsInlineFragment.graphql
-│       ├── QueryGetEmployeesByPetsNamedFragment.graphql
-│       ├── QueryGetEmployeeWithMood.graphql          # GraphQL query operation
-│       └── MutationUpdateEmployeeMood.graphql        # GraphQL mutation operation
-├── client/                  # Generated client code (committed to repo)
-│   └── employee/
-│       └── v1/
-│           ├── employeev1connect/  # Connect RPC client
-│           └── service.pb.go       # Protobuf types
-├── buf.yaml              # Buf configuration
-├── buf.gen.yaml          # Buf code generation config
-└── README.md             # This file
-```
-
-## Purpose
+To add a new service for testing:
 
-These proto files and GraphQL operations are used by the ConnectRPC server to:
-1. **Discover services** - Parse proto files to identify RPC services and methods
-2. **Load operations** - Read GraphQL operations that correspond to each RPC method
-3. **Generate handlers** - Create HTTP handlers that translate RPC calls to GraphQL requests
+1. Create a new directory under `services/` (e.g., `services/myservice.v1/`)
+2. Add your `.proto` file with service definitions - or generate it with `wgc grpc-service generate`
+3. Add corresponding `.graphql` files (GraphQL Executable Operations) for each RPC method
+4. The ConnectRPC server will automatically discover and load them
 
-## Testing
+### Example Structure
 
-The integration tests verify:
-- **Service discovery** (`router-tests/connectrpc_test.go`) - Proto files are correctly parsed and services are registered
-- **Operation loading** - GraphQL operations are loaded and associated with RPC methods
-- **Server lifecycle** - Server can start, reload, and stop correctly
-- **Router integration** - ConnectRPC works with the main router testenv
-- **E2E protocol tests** (`router-tests/connectrpc_client_test.go`) - All three RPC protocols (Connect, gRPC, gRPC-Web) work correctly
-- **Error handling** - GraphQL errors and HTTP status codes are properly mapped to Connect error codes
-- **Concurrency** - Multiple simultaneous requests are handled correctly
+```
+services/
+└── myservice.v1/
+    ├── service.proto                    # Proto service definition
+    ├── QueryGetItem.graphql            # GraphQL query operation
+    └── MutationCreateItem.graphql      # GraphQL mutation operation
+```
 
 ## Regenerating Client Code
 
-The `client/` directory contains generated client code used by the E2E tests. This code is **committed to the repository** to ensure tests work without requiring buf to be installed.
+The `client/` directory contains generated client code used by E2E tests. This code is **committed to the repository**.
 
 ### When to Regenerate
 
-You need to regenerate the client code when:
+Regenerate when:
 - Proto service definitions are modified (`services/*/service.proto`)
 - GraphQL operations are added, removed, or modified (`services/*/*.graphql`)
-- Message types are changed in proto files
-
-## Adding New Services
-
-To add a new service for testing:
-
-1. Create a new directory under `services/` (e.g., `services/myservice.v1/`)
-2. Add corresponding `.graphql` files (GraphQL Executable Operations)
-3. Add your `.proto` file with service definitions - or generate it with `wgc grpc-service generate`
-4. The ConnectRPC server will automatically discover and load them if configured to do so
+- Message types are changed in proto files

router-tests/testdata/connectrpc/README.md

@@ -5,11 +5,11 @@ managed:
     - file_option: go_package_prefix
       value: github.com/wundergraph/cosmo/router-tests/testdata/connectrpc/client
 plugins:
-  - remote: buf.build/protocolbuffers/go
+  - local: protoc-gen-go
     out: client
     opt:
       - paths=source_relative
-  - remote: buf.build/connectrpc/go
+  - local: protoc-gen-connect-go
     out: client
     opt:
-      - paths=source_relative
+      - paths=source_relative