-
-
Notifications
You must be signed in to change notification settings - Fork 283
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Any plans to use webrtc again for echo canceller? #3653
Comments
If possible yes. It is just that other things had higher priority. And usually the echo canceller from the speex library isn't so bad. I wonder if maybe the probes it has to put in the soundcard monitors made PipeWire to switch to a latency value that was too low for your device to handle. What is the output of |
As a reference for the future I will put here what seems to be a good example for the webrtc library https://gitlab.freedesktop.org/pulseaudio/webrtc-audio-processing/-/blob/master/examples/run-offline.cpp?ref_type=heads |
There is no issue as in crackling or similar, it's just that lower frequencies are cut off so, compared to my normal voice (or when not using the echo canceller), this sounds bad. Note:
Completely and utterly unrelated to this, but I think it's good to share info like this as finding the fix took me ages. |
Oh... I see. Unfortunately doing something about this is out of my reach. I wonder if putting the bass enhancer after the speex plugin can somehow "bring your lower frequencies back" 😄 |
From the issue I mention in my first comment:
I thought the problem with lower frequencies being cut off is because of speex and solution would be to use WebRTC (do correct me if I'm wrong). 🤔 I will try the bass enhancer later and see if thats better. |
This is the ideal solution. But while this isn't available it is worth to give the bass enhancer a shot. It is different than using a equalizer to boost low frequencies. The bass enhancer uses a psychoacoustic model to improve bass that takes as input higher frequency harmonics of the lower frequencies. And these might still be there after the speex libraries removes the echo. |
Still not as good as without EC, but its lil' bit better now. It removes some very annoying (imo) high frequencies and makes my voice seem more normal. Thanks for the suggestion. 🙏 If anyone comes across this and is interested, my current setup is (in order):
|
As the title says.
I'm experiencing the same issue as this one and my friends tell me my voice "sucks" when I turn on echo canceller. But I need it if I want to listen music because my headphones are really bad when it comes to echo.
The text was updated successfully, but these errors were encountered: