Skip to content

Commit 6977451

Browse files
authored
Undo order import changes (#5725)
1 parent cac9d97 commit 6977451

File tree

2 files changed

+5
-5
lines changed

2 files changed

+5
-5
lines changed

app/models/order_import.rb

Lines changed: 4 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -14,8 +14,8 @@ class OrderImport < ApplicationRecord
1414

1515
delegate :download_url, to: :error_file, prefix: true, allow_nil: true
1616

17-
def fetch_or_create_order(row_importer)
18-
order_cache[row_importer.order_key] || create_order_from_imported_row(row_importer)
17+
def fetch_or_create_order!(row_importer)
18+
order_cache[row_importer.order_key] || create_order_from_imported_row!(row_importer)
1919
end
2020

2121
#
@@ -74,8 +74,8 @@ def to_s
7474

7575
private
7676

77-
def create_order_from_imported_row(row_importer)
78-
Order.create(
77+
def create_order_from_imported_row!(row_importer)
78+
Order.create!(
7979
facility:,
8080
account: row_importer.account,
8181
user: row_importer.user,

app/services/order_row_importer.rb

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -141,7 +141,7 @@ def add_error(message, options = {})
141141
def add_to_order
142142
ActiveRecord::Base.transaction do
143143
begin
144-
@order = field(:order_number).present? ? existing_order : @order_import.fetch_or_create_order(self)
144+
@order = field(:order_number).present? ? existing_order : @order_import.fetch_or_create_order!(self)
145145

146146
# The order adding feature has some quirky behavior because of the "order form"
147147
# feature: if you add multiple of a timed service, it creates multiple line items

0 commit comments

Comments
 (0)