ci: tell the Claude reviewer to wait for its commands in the foreground - #1256
Conversation
On xability/r-maidr#305 the review started the tests in the background, ended its turn "until the wakeup", and the fallback step posted that sentence instead of a review: nothing resumes the session once the action's turn is over. Say so in the prompt, and point long runs at the Bash timeout instead. Co-Authored-By: Claude Fable 5.1 <noreply@anthropic.com>
ReviewWhat changed: a single paragraph added to the review prompt in Code quality
Bugs / correctness
Performance
Security
Test coverage / verification
OverallSmall, well-scoped, well-justified fix with a clear failure story in the description (the r-maidr#305 run that ended by scheduling a wakeup nothing would fire). Wording is consistent with the rest of the prompt and with the job's actual timeout configuration. No issues found — looks good to merge. 🤖 Generated with Claude Code |
🔎 MAIDR example preview is readyOpen the preview: https://pr-1256.maidr-preview.pages.dev
Built from |
What
One paragraph added to the review prompt:
Why
The first real review after #301/#302 landed, on xability/r-maidr#305, ran for 44 minutes and 68 turns, started
testthatandrcmdcheckin the background, and ended its turn with "I'll hold off here and resume once the background test run andrcmdcheckfinish (the wakeup I scheduled will bring me back)". In an action run nothing brings it back. The fallback step did its job, posting that sentence with a link to the run rather than losing it, but the PR got no review.The Bash timeouts the job sets (10 minutes by default, 30 at most) already cover a full
rcmdcheck; the prompt just did not say to use them.Verifying
actionlint 1.7.12withshellcheck 0.11.0: clean.🤖 Generated with Claude Code