Skip to content
This repository has been archived by the owner on Sep 25, 2024. It is now read-only.

Allow customization of resource dialog source selector label #239

Open
garuma opened this issue Mar 2, 2018 · 1 comment
Open

Allow customization of resource dialog source selector label #239

garuma opened this issue Mar 2, 2018 · 1 comment

Comments

@garuma
Copy link
Contributor

garuma commented Mar 2, 2018

screen shot 2018-03-01 at 8 31 45 pm

The current labels are "Local" and "Shared" which mean nothing in an Android context (rather they should be "Project" and "Framework").

When the ResourceSource is created on our side we do pass in those names but they don't seem to be bound in the UI.

@ermau
Copy link
Member

ermau commented Mar 2, 2018

The ResourceSource names are not for this, they are for placement locations / identification. They should be things like dimen, string, drawable, etc. "Local" and "Shared" are analogous to "Project" and "Framework" respectively.

We'll need some localization options for a few things, so we can look at adding this as part of that.

@ermau ermau added enhancement and removed bug labels Mar 2, 2018
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

No branches or pull requests

2 participants