Skip to content
This repository has been archived by the owner on Sep 25, 2024. It is now read-only.

Number: Needs keyboard controls #280

Open
vancura opened this issue Apr 12, 2018 · 3 comments
Open

Number: Needs keyboard controls #280

vancura opened this issue Apr 12, 2018 · 3 comments

Comments

@vancura
Copy link

vancura commented Apr 12, 2018

The Number input needs some keyboard controls to be usable without the mouse:

  • down / down: change by one point up or down,
  • shift+up / shift+ down: change by ten points up or down.

Where a point is a step which makes sense in the scenario:

  • with int values: 1 (with shift this becomes 10)
  • with float values, where the absolute maximum value is 1: 0.01f (with shift this becomes 0.1f),
  • with float values, where the absolute maximum value is bigger than 1: 0.1f (with shift this becomes 1f.

All of this needs to work not only on the TextField, but also the stepper if the keyboard tab navigation focuses it. When the focus is on stepper up/down buttons, both space and enter need to simulate click, and shift+space or shift+enter need to simulate ten clicks, similar to points described above.

Makes sense?

@ermau
Copy link
Member

ermau commented Apr 12, 2018

We have the most basic feature of this implemented, but it could do with more flushing out as suggested.

@vancura
Copy link
Author

vancura commented Apr 13, 2018

It would be a great user interface feature. You know, I am coming from design application world, where this is a usual thing, it improves how an app could be controlled with the keyboard. In the end, if Proppy is used with iOS, Android or any other visual designers/editors, we'd implement design-like behavior.

@alanmcgovern
Copy link
Contributor

Just worth bearing in mind - we are undergoing thorough accessibility testing at the moment so tasks like this may benefit from getting those results in first. We might be able to roll up a bunch of changes in one go :)

@ermau ermau added this to the Android Mac Target milestone May 16, 2018
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

No branches or pull requests

3 participants