Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Windows - 0.8.3 adding peers always replaces the middle of three peers #187

Open
rkroelin opened this issue Dec 23, 2024 · 12 comments
Open
Labels
bug Something isn't working peers Peer to peer connectivity

Comments

@rkroelin
Copy link

rkroelin commented Dec 23, 2024

When I attempt to add multiple peers with the default three, it continually replaces the second of the three. If I expand to 5 it replaces the fourth entry repeatedly.

Pretty sure adding peers worked last version?

@rkroelin rkroelin changed the title Windows - v.83 adding peers always replaces the middle of three peers Windows - 0.8.3 adding peers always replaces the middle of three peers Dec 23, 2024
@Rigidity
Copy link
Collaborator

You probably need to increase your Target Peers count in Settings

@rkroelin
Copy link
Author

Tried that..it connects to more peers automagically just fine but when I try to add mine manually it just cycles the same row. So if I try to add three of my local nodes, 1 2 3. First it puts #1 in the second row. Then it replaces that with #2 when I add it etc.

I would it expect to not replace the item I just added manually no matter how many target peers are an option. Unless there is one 1 peer set, then it would make sense :)

@rkroelin
Copy link
Author

Just tried turning off the auto-discover peer functionality and I still can't add more than one peer manually. It just swaps them continuously. Also doesn't seem to mark as trusted despite the setting.

Minor issue but thought i'd let you know. Also just saw the iOS update come down. Very cool.

@Rigidity
Copy link
Collaborator

Tried that..it connects to more peers automagically just fine but when I try to add mine manually it just cycles the same row. So if I try to add three of my local nodes, 1 2 3. First it puts #1 in the second row. Then it replaces that with #2 when I add it etc.

I would it expect to not replace the item I just added manually no matter how many target peers are an option. Unless there is one 1 peer set, then it would make sense :)

Got it, I can make it distinguish between manually added ones and prioritize removing automatic ones instead. And add an option to add multiple at once

@Rigidity
Copy link
Collaborator

Just tried turning off the auto-discover peer functionality and I still can't add more than one peer manually. It just swaps them continuously. Also doesn't seem to mark as trusted despite the setting.

Minor issue but thought i'd let you know. Also just saw the iOS update come down. Very cool.

You could try removing all the existing peers with auto discovery off, setting the target to the number you want to add, and adding them one by one. But I agree it's not ideal right now

@rkroelin
Copy link
Author

You could try removing all the existing peers with auto discovery off, setting the target to the number you want to add, and adding them one by one. But I agree it's not ideal right now

I tried this and the new entry just replaced the existing line. Wasn't possible to get the list to be longer than 1

@Rigidity
Copy link
Collaborator

Got it, I'll take a look tonight. Might be a regression

@Rigidity
Copy link
Collaborator

Ok this is fixed and will be resolved in the next release, thanks for reporting it.

@Rigidity
Copy link
Collaborator

If you're curious: #190

@rkroelin
Copy link
Author

Awesome. Tky.

@Rigidity Rigidity reopened this Dec 26, 2024
@Rigidity
Copy link
Collaborator

This is still an issue if you are full on peers, it needs to either be FIFO and/or prefer removing auto peers.

@rkroelin
Copy link
Author

With .8.4 this works now if autodiscover is off. However if it is on, the issue where it continually replaces the same line is still present.

20241226-0357-24.5087987.mp4

@Rigidity Rigidity added bug Something isn't working peers Peer to peer connectivity labels Jan 12, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working peers Peer to peer connectivity
Projects
Status: Done
Development

No branches or pull requests

2 participants