Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Transactions UI updates #318

Open
wants to merge 57 commits into
base: main
Choose a base branch
from
Open

Conversation

dkackman
Copy link
Contributor

@dkackman dkackman commented Feb 2, 2025

This PR will fix #302

It adds:

  • a list view for transactions
  • search capability
  • the ability to order by block #

Also

  • aligns some ui elements between transaction, nft and token pages
    • this involved a refactor of the token ui components so all three follow the same pattern of having an options component (with search, view options etc) separate from the individual views
  • makes settings available from login screen (to change network without having a wallet or logging into one)
  • replaces the useWallet hook with WalletContext since it is shared state across the majority of components.

@dkackman dkackman marked this pull request as draft February 2, 2025 01:58
@dkackman dkackman marked this pull request as ready for review February 5, 2025 01:59
@Ganbin
Copy link
Contributor

Ganbin commented Feb 9, 2025

Love it !

Very small details
The gap are not the same here : (might be my fault ^^)
2025-02-09_17-01-09

The rounded corners of the data-table are sometime not correctly display. Especially when hover a line (might need an overflow-hidden) and for the bottom corner. The Showing x rows seems also a little bit close to the table.
2025-02-09_17-03-23

@Ganbin
Copy link
Contributor

Ganbin commented Feb 9, 2025

When changing page size we should go back to page 1. For example if we are on page 200 with a page size of 25, switching to page size 100 make the page 200 to not exist and we see an empty table and we cannot go to page 1 easily.

Another design feature that I would prefer is to have the navigation both on top and on the bottom. I don't like to scroll down or up to navigate. But that is a design preference I know some prefer to have only 1 pagination on the bottom or on the top.

@dkackman
Copy link
Contributor Author

dkackman commented Feb 9, 2025

When changing page size we should go back to page 1. For example if we are on page 200 with a page size of 25, switching to page size 100 make the page 200 to not exist and we see an empty table and we cannot go to page 1 easily.

Another design feature that I would prefer is to have the navigation both on top and on the bottom. I don't like to scroll down or up to navigate. But that is a design preference I know some prefer to have only 1 pagination on the bottom or on the top.

addressed everything but the pagination at the bottom. I combined pagination into a component that acts as the header (with search and view options). Might take a slight redesign of that to have an additonal pagination control but i'll play around with it

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Sort and filter transaction list
2 participants