Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

BUG when creating offer using only copy/paste #315

Open
joshpainter opened this issue Jan 30, 2025 · 1 comment · May be fixed by #328
Open

BUG when creating offer using only copy/paste #315

joshpainter opened this issue Jan 30, 2025 · 1 comment · May be fixed by #328
Labels
bug Something isn't working offers Making or taking offers p-high High priority ui Display issue

Comments

@joshpainter
Copy link

Here's a weird one: when you create an offer, if you copy/paste the amounts into the amount fields instead of manually typing them in, the offer that is created will ignore that input but the offer will be created anyway. It will be created as a one-sided offer, leaving out the requested amounts entirely. This is really bad because the confirm screen right before you upload to Dexie doesn't give you any way to confirm the actual offer amounts, so you might accidentally upload a one-sided offer. Luckily Dexie flags these as invalid offers and doesn't show them, but if they change that then users could accidentally upload offers that will just give away their funds!

@joshpainter
Copy link
Author

A workaround is to paste the amounts in but then backspace over the last number, then manually type it in again.

@Rigidity Rigidity added bug Something isn't working ui Display issue offers Making or taking offers p-high High priority labels Jan 30, 2025
dkackman added a commit to dkackman/sage that referenced this issue Feb 7, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working offers Making or taking offers p-high High priority ui Display issue
Projects
Status: No status
Development

Successfully merging a pull request may close this issue.

2 participants