Skip to content

Commit 4d59c55

Browse files
committed
Update to Testcontainers v2
1 parent 67783a8 commit 4d59c55

File tree

4 files changed

+17
-21
lines changed

4 files changed

+17
-21
lines changed

testcontainers-advanced-imagebuilder/pom.xml

Lines changed: 8 additions & 12 deletions
Original file line numberDiff line numberDiff line change
@@ -57,18 +57,6 @@
5757
<groupId>org.testcontainers</groupId>
5858
<artifactId>testcontainers</artifactId>
5959
<version>2.0.0</version>
60-
<exclusions>
61-
<!-- No JUnit 4 -->
62-
<exclusion>
63-
<groupId>junit</groupId>
64-
<artifactId>junit</artifactId>
65-
</exclusion>
66-
</exclusions>
67-
</dependency>
68-
<dependency>
69-
<groupId>software.xdev</groupId>
70-
<artifactId>testcontainers-junit4-mock</artifactId>
71-
<version>1.0.2</version>
7260
</dependency>
7361
<!-- Testcontainers is using outdated v1 -->
7462
<dependency>
@@ -77,6 +65,14 @@
7765
<version>2.0.17</version>
7866
</dependency>
7967

68+
<!-- Explicitly declared to prevent incompatibilities -->
69+
<!-- Original comes transitively from Testcontainers -->
70+
<dependency>
71+
<groupId>commons-io</groupId>
72+
<artifactId>commons-io</artifactId>
73+
<version>2.20.0</version>
74+
</dependency>
75+
8076
<!-- Tests -->
8177
<dependency>
8278
<groupId>org.junit.jupiter</groupId>

testcontainers-advanced-imagebuilder/src/main/java/software/xdev/testcontainers/imagebuilder/AdvancedImageFromDockerFile.java

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -43,6 +43,8 @@
4343
import java.util.zip.GZIPOutputStream;
4444

4545
import org.apache.commons.compress.archivers.tar.TarArchiveOutputStream;
46+
import org.apache.commons.io.FileUtils;
47+
import org.apache.commons.lang3.function.TriFunction;
4648
import org.slf4j.Logger;
4749
import org.slf4j.LoggerFactory;
4850
import org.testcontainers.DockerClientFactory;
@@ -53,8 +55,6 @@
5355
import org.testcontainers.images.builder.traits.DockerfileTrait;
5456
import org.testcontainers.images.builder.traits.FilesTrait;
5557
import org.testcontainers.images.builder.traits.StringsTrait;
56-
import org.testcontainers.shaded.org.apache.commons.io.FileUtils;
57-
import org.testcontainers.shaded.org.apache.commons.lang3.function.TriFunction;
5858
import org.testcontainers.utility.Base58;
5959
import org.testcontainers.utility.DockerImageName;
6060
import org.testcontainers.utility.DockerLoggerFactory;

testcontainers-advanced-imagebuilder/src/main/java/software/xdev/testcontainers/imagebuilder/transfer/DefaultTransferFilesCreator.java

Lines changed: 5 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -39,10 +39,10 @@
3939
import java.util.stream.Collectors;
4040
import java.util.stream.Stream;
4141

42+
import org.apache.commons.io.FileUtils;
43+
import org.apache.commons.io.IOUtils;
4244
import org.slf4j.Logger;
4345
import org.slf4j.LoggerFactory;
44-
import org.testcontainers.shaded.org.apache.commons.io.FileUtils;
45-
import org.testcontainers.shaded.org.apache.commons.io.IOUtils;
4646

4747
import software.xdev.testcontainers.imagebuilder.jgit.ignore.FastIgnoreRule;
4848
import software.xdev.testcontainers.imagebuilder.jgit.ignore.IgnoreNode;
@@ -177,7 +177,7 @@ protected static Stream<Path> findFiles(
177177
: Files.find(start, maxDepth, matcher, options);
178178
}
179179

180-
@SuppressWarnings("java:S2789")
180+
@SuppressWarnings({"java:S2789", "OptionalAssignedToNull"})
181181
protected Map.Entry<Path, String> determineFileForTransfer(
182182
final IgnoreNode ignoreNode,
183183
final Set<String> alwaysIncludedRelativePaths,
@@ -213,7 +213,7 @@ protected Map.Entry<Path, String> determineFileForTransfer(
213213
return outcomeDirs;
214214
}
215215

216-
@SuppressWarnings("java:S2789")
216+
@SuppressWarnings({"java:S2789", "OptionalAssignedToNull"})
217217
protected Map.Entry<Path, String> determineParentDirectoryForTransfer(
218218
final IgnoreNode ignoreNode,
219219
final Set<String> alwaysIncludedRelativePaths,
@@ -261,7 +261,7 @@ protected String parentDirectory(final String dir)
261261
: null;
262262
}
263263

264-
@SuppressWarnings("java:S2789")
264+
@SuppressWarnings({"java:S2789", "OptionalAssignedToNull"})
265265
protected Optional<Map.Entry<Path, String>> shouldIgnore(
266266
final IgnoreNode ignoreNode,
267267
final Set<String> alwaysIncludedRelativePaths,

testcontainers-advanced-imagebuilder/src/main/java/software/xdev/testcontainers/imagebuilder/transfer/TransferArchiveTARCompressor.java

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -30,8 +30,8 @@
3030

3131
import org.apache.commons.compress.archivers.tar.TarArchiveEntry;
3232
import org.apache.commons.compress.archivers.tar.TarArchiveOutputStream;
33-
import org.testcontainers.shaded.org.apache.commons.io.FileUtils;
34-
import org.testcontainers.shaded.org.apache.commons.io.IOUtils;
33+
import org.apache.commons.io.FileUtils;
34+
import org.apache.commons.io.IOUtils;
3535

3636
import software.xdev.testcontainers.imagebuilder.transfer.fcm.FileContentModifier;
3737

0 commit comments

Comments
 (0)