-
Notifications
You must be signed in to change notification settings - Fork 655
build(deps): org.graalvm.buildtools:native-maven-plugin from 0.10.6 to 0.11.2 #1346
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
+14
−2
Merged
Changes from all commits
Commits
File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
|
|
@@ -331,7 +331,7 @@ | |
| <plugin> | ||
| <groupId>org.graalvm.buildtools</groupId> | ||
| <artifactId>native-maven-plugin</artifactId> | ||
| <version>0.10.6</version> | ||
| <version>0.11.2</version> | ||
| <extensions>true</extensions> | ||
| <executions> | ||
| <execution> | ||
|
|
@@ -346,6 +346,16 @@ | |
| <fallback>false</fallback> | ||
| <verbose>true</verbose> | ||
| <buildArgs> | ||
| <!-- | ||
| Only required for GraalVM for JDK 17. | ||
| The option is deprecated in later versions and could cause failures on later GraalVM versions. | ||
| --> | ||
| <arg>-H:+AllowDeprecatedBuilderClassesOnImageClasspath</arg> | ||
|
|
||
| <!-- | ||
| The initialization flags below seem only necessary for GraalVM for JDK 17 and 21. | ||
| If CI checks for either of these GraalVM versions are dropped, this should be cleaned up. | ||
| --> | ||
| <!-- required to allow junit-pioneer to compile with strict image heap enabled --> | ||
| <arg>--initialize-at-build-time=org.junitpioneer.jupiter.issue.IssueExtensionExecutionListener</arg> | ||
| <!-- | ||
|
|
@@ -357,6 +367,8 @@ | |
| <arg>--initialize-at-build-time=org.junit.jupiter.api.parallel.ResourceLock</arg> | ||
| <arg>--initialize-at-build-time=org.junit.jupiter.api.parallel.ResourceLockTarget</arg> | ||
| <arg>--initialize-at-build-time=org.junit.jupiter.api.parallel.ResourceAccessMode</arg> | ||
| <arg>--initialize-at-build-time=org.junit.jupiter.engine.descriptor.ExclusiveResourceCollector$1</arg> | ||
| <arg>--initialize-at-build-time=org.junit.platform.commons.support.scanning.DefaultClasspathScanner</arg> | ||
|
Contributor
Author
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Most of these initialization options seem to no longer be required on JDK 25. They're only here for 17 and 21. |
||
| </buildArgs> | ||
| </configuration> | ||
| </plugin> | ||
|
|
||
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This is only necessary for GraalVM JDK 17. On later versions this option is deprecated so at some point this might cause failures if the option is removed. At that point I would recommend just dropping builds for GraalVM JDK 17.