Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Broken image #6

Open
idkq opened this issue Mar 3, 2022 · 6 comments
Open

Broken image #6

idkq opened this issue Mar 3, 2022 · 6 comments

Comments

@idkq
Copy link

idkq commented Mar 3, 2022

image

@miszterx
Copy link

miszterx commented Apr 1, 2022

I have just checked the live demo page: http://castaway.xesf.net/#entry=MJFISH.TTM
But it has the same issue.

Were you tried in your own install?

@xesf
Copy link
Owner

xesf commented Apr 6, 2022

I think we do have some issues with contexts between scenes causing this.
The latest version is not the same as the live demo version so I am not sure this still remains.

The whole scene context and ads player needs to be rebuilt and simplified, there are a lot of issues with the way I have shared the objects between the calls.

There is actually a better implementation in C of the player here: https://github.com/jno6809/jc_reborn

@miszterx
Copy link

miszterx commented Apr 6, 2022

Thanks! Unfortunately I am on macos and I cannot compile it. This is why it was so cool to make it on a webserver on a linux box and publish.

I have tried to use the latest code, and it is partially working, but buggy as you said.

I wish you have time to one day refresh the project again. I will watch for sure.
Thanks!

@xesf
Copy link
Owner

xesf commented Apr 6, 2022

Strange, have a look at my pending PR: jno6809/jc_reborn#10
I also use Mac OS and I have pushed a makefile for mac together with this PR.

I still want to keep working on this project (just parked for now).
I think it can actually have some amazing features for the web, specially in the stats category and it will always be easy to get up and running. These days every device has a browser that most likely will be compatible with johnny castaway.

@miszterx
Copy link

miszterx commented Apr 6, 2022

Ohh! If you have compiled version of jc_reborn for mac can you share somehow?

I am glad that you want to work on this web implementation. I can see also a better choice this one.

@xesf
Copy link
Owner

xesf commented Apr 6, 2022

It is not a packaged version so not sure you will need some dependencies, but I can check what I have later and send it to you. I don't have my laptop with me know where I have those.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants