Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Dark mode issue #2102

Open
BEST8OY opened this issue Jan 24, 2025 · 5 comments
Open

Dark mode issue #2102

BEST8OY opened this issue Jan 24, 2025 · 5 comments

Comments

@BEST8OY
Copy link
Contributor

BEST8OY commented Jan 24, 2025

Describe the bug
One particular dictionary mess with dark mode engine.
If I disable that dictionary the problem goes away
I'm not sure to say if this is a GD bug or dictionary bug!
In v24.09.0-Release.316ec900 it only affect the background slightly (makes it darker)
In v25.2.0-Release.9caa1683 it makes background darker and other elements weird in color.
I have to mention that I'm using this article script.

Image

The weird thing is that when I select an entry that has this problem it becomes okay after several tries!
It even fixes the darker background somehow

outputfile.mp4

 
Expected behavior
It should be like previous version at least and I want it to not mess with anything more than background

Screenshots

In v24.09.0-Release.316ec900

An entry that the mentioned dictionary doesn't have
Image

An entry that the mentioned dictionary has
Image

In v25.2.0-Release.9caa1683

An entry that the mentioned dictionary doesn't have
Image

An entry that the mentioned dictionary has
Image

To Reproduce
1.Use latest version
2.Use this dictionary

OS and software versions

  • OS: Arch Linux
@BEST8OY
Copy link
Contributor Author

BEST8OY commented Feb 3, 2025

I found another dictionary that causes the same issue
Now, I can safely say it has nothing to do with custom article-script.js if there was any doubt!

outputf.mp4

@xiaoyifang
Copy link
Owner

you can use F12 to inspect the element and found out which style has taken effect and where does the style come from.

@BEST8OY
Copy link
Contributor Author

BEST8OY commented Feb 4, 2025

Image
It's fallback colors
Why do they get activated? and why do they no get activated after several try as it's shown in original post video?

@xiaoyifang
Copy link
Owner

which dictionary has introduced the style html?

@BEST8OY
Copy link
Contributor Author

BEST8OY commented Feb 5, 2025

What do you mean?
Isn't it darkreader.js making those colors?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants