feat: auto-refresh mono comments after publish and refactor flow collection style

Author: xiaoyvyv

features/mono/detail/src/commonMain/kotlin/com/xiaoyv/bangumi/features/mono/detail/business/MonoDetailViewModel.kt

@@ -15,6 +15,7 @@ import com.xiaoyv.bangumi.shared.core.mvi.reduceData
 import com.xiaoyv.bangumi.shared.core.mvi.reduceError
 import com.xiaoyv.bangumi.shared.core.mvi.withActionLoading
 import com.xiaoyv.bangumi.shared.core.types.MonoType
+import com.xiaoyv.bangumi.shared.core.types.PublishPostType
 import com.xiaoyv.bangumi.shared.core.utils.awaitAll
 import com.xiaoyv.bangumi.shared.core.utils.mutableStateFlowOf
 import com.xiaoyv.bangumi.shared.data.manager.app.PersonalStateStore
@@ -34,9 +35,8 @@ import kotlinx.collections.immutable.toPersistentList
 import kotlinx.coroutines.flow.filter
 import kotlinx.coroutines.flow.filterNotNull
 import kotlinx.coroutines.flow.flatMapLatest
-import kotlinx.coroutines.flow.launchIn
-import kotlinx.coroutines.flow.onEach
 import kotlinx.coroutines.flow.update
+import kotlinx.coroutines.launch
 import org.jetbrains.compose.resources.getString
 import org.orbitmvi.orbit.syntax.Syntax
 
@@ -82,15 +82,27 @@ class MonoDetailViewModel(
         .cachedIn(viewModelScope)
 
     init {
-        personalStateStore.onMonoUpdated
-            .filter { it.id == args.id }
-            .onEach { event ->
-                intent {
-                    reduceData { state.copy(mono = event.data) }
-                    saveCache()
+        viewModelScope.launch {
+            personalStateStore.onMonoUpdated
+                .filter { it.id == args.id }
+                .collect { event ->
+                    intent {
+                        reduceData { state.copy(mono = event.data) }
+                        saveCache()
+                    }
                 }
-            }
-            .launchIn(viewModelScope)
+        }
+
+        viewModelScope.launch {
+            personalStateStore.publishSuccess
+                .filter {
+                    it.type == PublishPostType.COMMENT_CHARACTER && args.type == MonoType.CHARACTER && it.publishAttachId.toLongOrNull() == args.id
+                            || it.type == PublishPostType.COMMENT_PERSON && args.type == MonoType.PERSON && it.publishAttachId.toLongOrNull() == args.id
+                }
+                .collect {
+                    onRefreshComments()
+                }
+        }
     }
 
     override fun initBaseState() = readViewModelCache(
@@ -198,6 +210,16 @@ class MonoDetailViewModel(
             }
     }
 
+    private fun onRefreshComments() = intent {
+        if (args.type == MonoType.CHARACTER) {
+            monoRepository.fetchMonoComments(args.id, MonoType.CHARACTER)
+        } else {
+            monoRepository.fetchMonoComments(args.id, MonoType.PERSON)
+        }.onSuccess {
+            reduceData { state.copy(comments = it.toPersistentList()) }
+        }
+    }
+
 
     private fun onReactionClick(comment: ComposeReply, reaction: ComposeReaction) = intent {
         val isLiked = reaction.users.any { it.username == userManager.userInfo.username }

features/mono/detail/src/commonMain/kotlin/com/xiaoyv/bangumi/features/mono/detail/page/MonoDetailMainScreen.kt

@@ -209,7 +209,7 @@ fun MonoDetailMainScreen(
                         onActionEvent(MonoDetailEvent.Action.OnReactionClick(item, it))
                     }
                 )
-                HorizontalDivider()
+                if (index != state.comments.lastIndex) HorizontalDivider()
             }
 
             itemKey(ItemNoMore) {

features/subject/detail/src/commonMain/kotlin/com/xiaoyv/bangumi/features/subject/detail/business/SubjectDetailViewModel.kt

@@ -35,8 +35,7 @@ import kotlinx.collections.immutable.toPersistentList
 import kotlinx.coroutines.async
 import kotlinx.coroutines.coroutineScope
 import kotlinx.coroutines.flow.filter
-import kotlinx.coroutines.flow.launchIn
-import kotlinx.coroutines.flow.onEach
+import kotlinx.coroutines.launch
 import org.jetbrains.compose.resources.getString
 import org.orbitmvi.orbit.syntax.Syntax
 
@@ -57,19 +56,19 @@ class SubjectDetailViewModel(
 ) : BaseViewModel<SubjectDetailState, SubjectDetailSideEffect, SubjectDetailEvent.Action>() {
 
 
-
     private val cacheKey = stringPreferencesKey(name = "subject_detail_" + args.subjectId)
 
     init {
-        personalStateStore.onSubjectUpdated
-            .filter { it.id == args.subjectId }
-            .onEach { event ->
-                intent {
-                    reduceData { state.copy(subject = event.data) }
-                    saveCache()
+        viewModelScope.launch {
+            personalStateStore.onSubjectUpdated
+                .filter { it.id == args.subjectId }
+                .collect { event ->
+                    intent {
+                        reduceData { state.copy(subject = event.data) }
+                        saveCache()
+                    }
                 }
-            }
-            .launchIn(viewModelScope)
+        }
     }
 
     override fun initBaseState() = readViewModelCache(

features/timeline/detail/src/commonMain/kotlin/com/xiaoyv/bangumi/features/timeline/detail/business/TimelineDetailViewModel.kt

@@ -20,8 +20,7 @@ import com.xiaoyv.bangumi.shared.data.repository.TimelineRepository
 import com.xiaoyv.bangumi.shared.ui.component.navigation.Screen
 import kotlinx.collections.immutable.toImmutableList
 import kotlinx.coroutines.flow.filter
-import kotlinx.coroutines.flow.launchIn
-import kotlinx.coroutines.flow.onEach
+import kotlinx.coroutines.launch
 import org.orbitmvi.orbit.syntax.Syntax
 
 /**
@@ -38,12 +37,13 @@ class TimelineDetailViewModel(
 ) : BaseViewModel<TimelineDetailState, TimelineDetailSideEffect, TimelineDetailEvent.Action>() {
 
     init {
-        personalStateStore.onTimelineUpdated
-            .filter { it.id == args.timeline.id }
-            .onEach { event ->
-                intent { reduceData { state.copy(timeline = event.data) } }
-            }
-            .launchIn(viewModelScope)
+        viewModelScope.launch {
+            personalStateStore.onTimelineUpdated
+                .filter { it.id == args.timeline.id }
+                .collect { event ->
+                    intent { reduceData { state.copy(timeline = event.data) } }
+                }
+        }
     }
 
     override fun initBaseState(): UiState<TimelineDetailState> = UiState(