Skip to content

Commit f66709d

Browse files
committed
Back to one xtensor-zarr-gdal shared library
1 parent 8e190bf commit f66709d

5 files changed

+8
-27
lines changed

CMakeLists.txt

-6
Original file line numberDiff line numberDiff line change
@@ -109,10 +109,6 @@ set(XTENSOR_ZARR_HEADERS
109109
${XTENSOR_ZARR_INCLUDE_DIR}/xtensor-zarr/xtensor_zarr_config_cling.hpp
110110
)
111111

112-
set(XTENSOR_ZARR_LOCAL_SOURCE
113-
${XTENSOR_ZARR_SOURCE_DIR}/xtensor-zarr-local.cpp
114-
)
115-
116112
set(XTENSOR_ZARR_GDAL_SOURCE
117113
${XTENSOR_ZARR_SOURCE_DIR}/xtensor-zarr-gdal.cpp
118114
)
@@ -305,9 +301,7 @@ endmacro()
305301

306302
set (xtensor_zarr_targets "")
307303
if (XTENSOR_ZARR_BUILD_SHARED_LIBS)
308-
xtensor_zarr_create_target(${XTENSOR_ZARR_LOCAL_SOURCE} xtensor-zarr-local SHARED xtensor-zarr-local)
309304
xtensor_zarr_create_target(${XTENSOR_ZARR_GDAL_SOURCE} xtensor-zarr-gdal SHARED xtensor-zarr-gdal)
310-
list(APPEND xtensor_zarr_targets xtensor-zarr-local)
311305
list(APPEND xtensor_zarr_targets xtensor-zarr-gdal)
312306

313307
target_link_libraries(xtensor-zarr-gdal

README.md

+3-10
Original file line numberDiff line numberDiff line change
@@ -13,25 +13,18 @@ Implementation of the Zarr core protocol (version 2 and 3) based on xtensor
1313

1414
## Installation
1515

16-
`xtensor-zarr` comes with:
17-
18-
- `libxtensor-zarr-gdal`: a shared library for accessing stores through a GDAL Virtual File System.
19-
- `libxtensor-zarr-local`: a shared library for accessing stores through the local file system.
20-
21-
Appart from these stores, `xtensor-zarr` is a header-only library.
16+
`xtensor-zarr` comes with a `libxtensor-zarr-gdal` shared library for accessing stores through GDAL's Virtual File System or the local file system. For all other stores, `xtensor-zarr` is a header-only library.
2217

2318
We provide a package for the mamba (or conda) package manager:
2419

2520
```bash
2621
mamba install xtensor-zarr -c conda-forge
2722
```
2823

29-
- `xtensor-zarr` depends on `xtensor` `^0.23.8`, `xtensor-io` `^0.12.7`, `zarray` `^0.0.7`, `nlohmann_json` `^3.9.1`, `Blosc` `^1.21.0` and `zlib` `^1.2.11`.
24+
- `xtensor-zarr` depends on `xtensor` `^0.23.8`, `xtensor-io` `^0.12.7`, `zarray` `^0.0.7`, `nlohmann_json` `^3.9.1`, `Blosc` `^1.21.0`, `zlib` `^1.2.11`, `gdal` `^3.0.0` and `cpp-filesystem` `^1.3.0`.
3025

31-
- `gdal` `^3.0.0`, `cpp-filesystem` `^1.3.0`, `google-cloud-cpp` and `aws-sdk-cpp` are optional dependencies to `xtensor-zarr`.
26+
- `google-cloud-cpp` and `aws-sdk-cpp` are optional dependencies to `xtensor-zarr`.
3227

33-
- `gdal` is required to access a store using GDAL's Virtual File System.
34-
- `cpp-filesystem` is required to access a store in the local file system.
3528
- `google-cloud-cpp` is required to access a store in Google Cloud Storage.
3629
- `aws-sdk-cpp` is required to access a store in AWS S3.
3730

src/xtensor-zarr-gdal.cpp

+5
Original file line numberDiff line numberDiff line change
@@ -2,6 +2,11 @@
22

33
namespace xt
44
{
5+
template XTENSOR_ZARR_API void xzarr_register_compressor<xzarr_file_system_store, xio_gzip_config>();
6+
template XTENSOR_ZARR_API void xzarr_register_compressor<xzarr_file_system_store, xio_zlib_config>();
7+
template XTENSOR_ZARR_API void xzarr_register_compressor<xzarr_file_system_store, xio_blosc_config>();
8+
template class XTENSOR_ZARR_API xchunked_array_factory<xzarr_file_system_store>;
9+
510
template XTENSOR_ZARR_API void xzarr_register_compressor<xzarr_gdal_store, xio_gzip_config>();
611
template XTENSOR_ZARR_API void xzarr_register_compressor<xzarr_gdal_store, xio_zlib_config>();
712
template XTENSOR_ZARR_API void xzarr_register_compressor<xzarr_gdal_store, xio_blosc_config>();

src/xtensor-zarr-local.cpp

-9
This file was deleted.

test/CMakeLists.txt

-2
Original file line numberDiff line numberDiff line change
@@ -12,7 +12,6 @@ cmake_minimum_required(VERSION 3.8)
1212
if (CMAKE_CURRENT_SOURCE_DIR STREQUAL CMAKE_SOURCE_DIR)
1313
project(xtensor-zarr-test)
1414

15-
find_package(xtensor-zarr-local REQUIRED CONFIG)
1615
find_package(xtensor-zarr-gdal REQUIRED CONFIG)
1716
find_package(xtensor-zarr REQUIRED CONFIG)
1817
set(XTENSOR_ZARR_INCLUDE_DIR ${xtensor_INCLUDE_DIRS})
@@ -102,7 +101,6 @@ target_compile_features(test_xtensor_zarr PRIVATE cxx_std_14)
102101

103102
target_link_libraries(test_xtensor_zarr
104103
PRIVATE
105-
xtensor-zarr-local
106104
xtensor-zarr-gdal
107105
PUBLIC
108106
xtensor-zarr

0 commit comments

Comments
 (0)