Add a bounds check and negative slice support to strided view fill_args

Ivorforce · Ivorforce · commit c4724db9ab0e · 2025-04-29T02:29:27.000+02:00
diff --git a/include/xtensor/views/xstrided_view_base.hpp b/include/xtensor/views/xstrided_view_base.hpp
@@ -903,6 +903,11 @@ namespace xt
                     if (ptr != nullptr)
                     {
                         auto slice0 = static_cast<old_strides_value_type>(*ptr);
+            	        if (slice0 < 0) slice0 += shape[i_ax];
+            	        if (slice0 < 0 || slice0 >= shape[i_ax])
+                        {
+                            XTENSOR_THROW(std::runtime_error, "Slice index out of range.");
+                        }
                         new_offset += static_cast<std::size_t>(slice0 * old_strides[i_ax]);
                     }
                     else if (std::get_if<xt::xnewaxis_tag>(&slices[i]) != nullptr)

Original file line number	Diff line number	Diff line change
`@@ -903,6 +903,11 @@ namespace xt`
`903`	`903`	`if (ptr != nullptr)`
`904`	`904`	`{`
`905`	`905`	`auto slice0 = static_cast<old_strides_value_type>(*ptr);`
	`906`	`+ if (slice0 < 0) slice0 += shape[i_ax];`
	`907`	`+ if (slice0 < 0 \|\| slice0 >= shape[i_ax])`
	`908`	`+ {`
	`909`	`+ XTENSOR_THROW(std::runtime_error, "Slice index out of range.");`
	`910`	`+ }`
`906`	`911`	`new_offset += static_cast<std::size_t>(slice0 * old_strides[i_ax]);`
`907`	`912`	`}`
`908`	`913`	`else if (std::get_if<xt::xnewaxis_tag>(&slices[i]) != nullptr)`