Skip to content
This repository has been archived by the owner on Aug 22, 2022. It is now read-only.

Breaking change detection #4

Open
xuorig opened this issue Jul 28, 2021 · 1 comment
Open

Breaking change detection #4

xuorig opened this issue Jul 28, 2021 · 1 comment
Labels
enhancement New feature or request

Comments

@xuorig
Copy link
Owner

xuorig commented Jul 28, 2021

Currently anicca only computes differences but has no opinion on whether these changes are safe to make or not. We could add a breaking method on diff objects to solve that.

Then there's also some philosophical questions about whether a change is breaking or not. A change could be breaking to tools consuming OpenAPI, but not necessarily to the runtime of an API represented by this OpenAPI document. Do we differ between the two? Pick one?

@xuorig xuorig added the enhancement New feature or request label Jul 28, 2021
@gr2m
Copy link

gr2m commented Aug 18, 2021

I think I'd leave breaking change detection to a secondary tool which can work with the output of anicca. That way folks can implement their own rules of what changes are handled as breaking changes and what others are not

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

2 participants