Adding Sentinel Commands #8
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The basic mechanics are here and will need to be extended. This will include the completion of the struct definitions and their construction
Also improved some of the documentation of the struct
Moved the code which builds the MasterInfo struct to it's own method in favor of DRY when adding the SentinelMasters command which will return a list of Masters being managed. I'm not sure if it should return a list or if it should return a map[string]MasterInfo. Leaning toward the latter.
Adding detailed docs for Sentinel commands, finished adding Sentinel commands.
Added documentation on the structs the file exports as well as correcting "This command" to "This method".
Added tests for sentinel. Mainly testing the building of Structs from a map[string]string. Moved build*Struct methods to be unexported *Redis methods to enable testing.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds a new set of methods/commands used for talking to a Redis Sentinel server. It introduces no dependencies, has tests for the non-trivial methods, embedded doc comments, and an additional markdown file detailing usage of the new methods.
This new set of supported commands are useful in interrogating a Redis sentinel as well as implementing Sentinel support (either in client code or in the library itself).
Note, this implements the sentinel aspect of issue #7.