Skip to content

Commit 8754f9c

Browse files
committed
update doc for feedbacks
1 parent 9203666 commit 8754f9c

File tree

2 files changed

+4
-4
lines changed

2 files changed

+4
-4
lines changed

docs/api/setupI13n.md

+3-3
Original file line numberDiff line numberDiff line change
@@ -27,16 +27,16 @@ var I13nDempApp = setupI13n(DemoApp, {
2727
}, [someReactI13nPlugin]);
2828

2929
// then you could use I13nDemoApp to render you app
30+
```
3031

3132
### Create and access the ReactI13n instance
3233

3334
What we do with `setupI13n` is that we will create the `ReactI13n` instance, along with a root node of the I13nTree, passing them via component context to the children.
3435

35-
It's designed to work within React components, you should be able to just [utilFuctions](https://github.com/yahoo/react-i13n/blob/master/docs/guides/utilFunctions.md) and trigger i13n events. In case you want to do this out of React components, you can access `window._reactI13nInstance` directly.
36+
It's designed to work within React components, you should be able to just use [utilFuctions](https://github.com/yahoo/react-i13n/blob/master/docs/guides/utilFunctions.md) and trigger i13n events. In case you want to do this out of React components, you can access `window._reactI13nInstance` directly.
3637

37-
If you have multiple react trees in one page, we will create multiple i13n trees based on how many react tree you have. On client side the [utilFuctions](https://github.com/yahoo/react-i13n/blob/master/docs/guides/utilFunctions.md) still work based on the global instance object, while on server side, only the children under `setupI13n` can get the react i13n instance as we don't have a proper way to share the reactI13n instance without causing [memory leak](https://github.com/yahoo/react-i13n/pull/100).
38+
If you have multiple React trees in one page, we will create multiple i13n trees based on how many React tree you have. On client side the [utilFuctions](https://github.com/yahoo/react-i13n/blob/master/docs/guides/utilFunctions.md) still work based on the global instance object, while on server side, only the children under `setupI13n` can get the React i13n instance as we don't have a proper way to share the ReactI13n instance without causing [memory leak](https://github.com/yahoo/react-i13n/pull/100).
3839

39-
```
4040

4141
### Util Functions
4242

src/mixins/I13nMixin.js

+1-1
Original file line numberDiff line numberDiff line change
@@ -366,7 +366,7 @@ var I13nMixin = {
366366
var self = this;
367367
var parentI13nNode = self._getParentI13nNode();
368368
var reactI13n = self._getReactI13n();
369-
var I13nNodeClass = (reactI13n && reactI13n.getI13nNodeClass()) || I13nNode;;
369+
var I13nNodeClass = (reactI13n && reactI13n.getI13nNodeClass()) || I13nNode;
370370
// TODO @kaesonho remove BC for model
371371
self._i13nNode = new I13nNodeClass(
372372
parentI13nNode,

0 commit comments

Comments
 (0)