Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Helm chart: common labels #35

Open
MikailBag opened this issue Feb 11, 2025 · 0 comments
Open

Helm chart: common labels #35

MikailBag opened this issue Feb 11, 2025 · 0 comments

Comments

@MikailBag
Copy link
Contributor

Motivation

Imagine a world where #19 is done, i.e. one Perforator spans across multiple Kubernetes clusters. These clusters will be definitely different in some ways, i.e. they can be located in different zones and regions. There should be a way to reflect it in labels.

Note that agent already retrieves Node topology information (usually topology.kubernetes.io/zone) and adds corresponding label. These are two distinct features: distinguishing profiles within cluster (based on cluster topology) vs distinguishing profiles across clusters (based on cluster fleet topology)

Proposed interface

Modify values as follows (naming TBD):

agent:
  config:
    commonLabels:
      region: region1

(User then needs to correctly override agent.profiler.commonLabels for each workload cluster, but it is out-of-scope for us).

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant