Skip to content

Commit 3190722

Browse files
authored
clean up: remove redundant imports (dlt-hub#2353)
* Remove duplicate import * Clean up duplicate/unused imports in rest_api.typing * Remove more redundant imports
1 parent 63de7c5 commit 3190722

File tree

10 files changed

+6
-31
lines changed

10 files changed

+6
-31
lines changed

dlt/common/configuration/providers/__init__.py

-1
Original file line numberDiff line numberDiff line change
@@ -8,7 +8,6 @@
88
CONFIG_TOML,
99
SECRETS_TOML,
1010
StringTomlProvider,
11-
CustomLoaderDocProvider,
1211
)
1312
from .doc import CustomLoaderDocProvider
1413
from .vault import SECRETS_TOML_KEY

dlt/destinations/dataset/__init__.py

+3-7
Original file line numberDiff line numberDiff line change
@@ -1,10 +1,6 @@
1-
from dlt.destinations.dataset.factory import (
2-
dataset,
3-
)
4-
from dlt.destinations.dataset.dataset import (
5-
ReadableDBAPIDataset,
6-
get_destination_clients,
7-
)
1+
from dlt.destinations.dataset.factory import dataset
2+
from dlt.destinations.dataset.dataset import ReadableDBAPIDataset
3+
84
from dlt.destinations.dataset.utils import (
95
get_destination_clients,
106
get_destination_client_initial_config,

dlt/destinations/impl/filesystem/filesystem.py

-1
Original file line numberDiff line numberDiff line change
@@ -19,7 +19,6 @@
1919
Dict,
2020
)
2121
from fsspec import AbstractFileSystem
22-
from contextlib import contextmanager
2322

2423
import dlt
2524
from dlt.common import logger, time, json, pendulum

dlt/destinations/impl/synapse/configuration.py

-1
Original file line numberDiff line numberDiff line change
@@ -8,7 +8,6 @@
88
MsSqlCredentials,
99
MsSqlClientConfiguration,
1010
)
11-
from dlt.destinations.impl.mssql.configuration import MsSqlCredentials
1211

1312
from dlt.destinations.impl.synapse.synapse_adapter import TTableIndexType
1413

dlt/destinations/utils.py

+1-2
Original file line numberDiff line numberDiff line change
@@ -1,6 +1,6 @@
11
import re
22

3-
from typing import Any, List, Optional, Sequence, Tuple
3+
from typing import Any, List, Dict, Type, Optional, Sequence, Tuple, cast
44

55
from dlt.common import logger
66
from dlt.common.destination.capabilities import DestinationCapabilitiesContext
@@ -15,7 +15,6 @@
1515
is_nested_table,
1616
pipeline_state_table,
1717
)
18-
from typing import Any, cast, Tuple, Dict, Type
1918

2019
from dlt.destinations.exceptions import DatabaseTransientException
2120
from dlt.extract import DltResource, resource as make_resource, DltSource

dlt/extract/reference.py

+2-2
Original file line numberDiff line numberDiff line change
@@ -7,11 +7,11 @@
77
Any,
88
Generic,
99
Tuple,
10-
cast,
1110
overload,
11+
ClassVar,
12+
Type,
1213
)
1314
from typing_extensions import Self, TypeVar
14-
from typing import Dict, Type, ClassVar
1515

1616
from dlt.common import logger
1717
from dlt.common.configuration.specs import BaseConfiguration, known_sections

dlt/extract/source.py

-1
Original file line numberDiff line numberDiff line change
@@ -12,7 +12,6 @@
1212
Any,
1313
)
1414
from typing_extensions import Self
15-
from typing import Dict
1615

1716
from dlt.common.configuration.resolve import inject_section
1817
from dlt.common.configuration.specs import known_sections

dlt/extract/utils.py

-1
Original file line numberDiff line numberDiff line change
@@ -39,7 +39,6 @@
3939
)
4040
from dlt.extract.items import (
4141
TTableHintTemplate,
42-
TDataItem,
4342
TFunHintTemplate,
4443
SupportsPipe,
4544
)

dlt/pipeline/pipeline.py

-1
Original file line numberDiff line numberDiff line change
@@ -73,7 +73,6 @@
7373
WithStateSync,
7474
JobClientBase,
7575
DestinationClientStagingConfiguration,
76-
DestinationClientStagingConfiguration,
7776
)
7877
from dlt.common.destination.dataset import SupportsReadableDataset
7978
from dlt.common.destination.typing import TDatasetType

dlt/sources/rest_api/typing.py

-14
Original file line numberDiff line numberDiff line change
@@ -1,5 +1,3 @@
1-
from dataclasses import dataclass, field
2-
31
from typing import (
42
Any,
53
Callable,
@@ -22,17 +20,6 @@
2220

2321
from dataclasses import dataclass, field
2422

25-
from dlt.common import jsonpath
26-
from dlt.common.typing import TSortOrder, TColumnNames
27-
from dlt.common.schema.typing import (
28-
TTableFormat,
29-
TAnySchemaColumns,
30-
TWriteDispositionConfig,
31-
TSchemaContract,
32-
)
33-
34-
from dlt.extract.items import TTableHintTemplate
35-
from dlt.common.incremental.typing import LastValueFunc
3623
from dlt.extract.resource import DltResource
3724

3825
from requests import Session
@@ -47,7 +34,6 @@
4734
PageNumberPaginator,
4835
SinglePagePaginator,
4936
)
50-
from dlt.sources.helpers.rest_client.typing import HTTPMethodBasic
5137

5238

5339
try:

0 commit comments

Comments
 (0)