From 7da69f6138bee10bd6ca920819b40356ac0afccf Mon Sep 17 00:00:00 2001 From: Stephanie Nathai-Cueter Date: Fri, 20 Oct 2023 12:43:53 -0400 Subject: [PATCH 1/2] fix(a11y): reducing 50% of a11y issues on contributor page --- _sass/_contributing.scss | 4 ++++ contributing/index.html | 8 ++++---- 2 files changed, 8 insertions(+), 4 deletions(-) diff --git a/_sass/_contributing.scss b/_sass/_contributing.scss index fadfadc..ccb4829 100644 --- a/_sass/_contributing.scss +++ b/_sass/_contributing.scss @@ -9,4 +9,8 @@ font-size: 1.2em; padding: 1em 0 0; } + + a { + text-decoration: underline; + } } \ No newline at end of file diff --git a/contributing/index.html b/contributing/index.html index c2099dd..602831c 100644 --- a/contributing/index.html +++ b/contributing/index.html @@ -22,7 +22,7 @@
  1. Look through the existing issues and see if your idea is something new.
  2. -
  3. Create a new issue , or comment on an existing issue that you would like to help solve: +
  4. Create a new issue, or comment on an existing issue that you would like to help solve:
    • it's usually best to get some feedback before proceeding to write code. ,
    @@ -30,15 +30,15 @@
  5. fork the yargs repo, and clone it to your computer:
  6. make sure that you write unit-test for any code that you write for yargs:
      -
    • we use standard coding style, which will validate your style when you run tests
    • +
    • we use standard coding style, which will validate your style when you run tests
    • -
    • look through our extensive test suite in /test to get an idea for how to write unit-tests for this codebase.
    • +
    • look through our extensive test suite in /test to get an idea for how to write unit-tests for this codebase.
  7. From 929adf3210c0368736f9379c72842b4766f14365 Mon Sep 17 00:00:00 2001 From: Stephanie Nathai-Cueter Date: Mon, 23 Oct 2023 09:37:46 -0400 Subject: [PATCH 2/2] fix(a11y): removing leading spaces --- contributing/index.html | 8 ++++---- 1 file changed, 4 insertions(+), 4 deletions(-) diff --git a/contributing/index.html b/contributing/index.html index 602831c..bd3e1ab 100644 --- a/contributing/index.html +++ b/contributing/index.html @@ -22,7 +22,7 @@
    1. Look through the existing issues and see if your idea is something new.
    2. -
    3. Create a new issue, or comment on an existing issue that you would like to help solve: +
    4. Create a new issue, or comment on an existing issue that you would like to help solve:
      • it's usually best to get some feedback before proceeding to write code. ,
      @@ -30,15 +30,15 @@
    5. fork the yargs repo, and clone it to your computer:
    6. make sure that you write unit-test for any code that you write for yargs:
        -
      • we use standard coding style, which will validate your style when you run tests
      • +
      • we use standard coding style, which will validate your style when you run tests
      • -
      • look through our extensive test suite in /test to get an idea for how to write unit-tests for this codebase.
      • +
      • look through our extensive test suite in /test to get an idea for how to write unit-tests for this codebase.