Skip to content

Commit 957172d

Browse files
authored
Merge pull request #18040 from alexvru/merge/25-1-1/18012
Fix BSC VDisk metrics unknown fields exchange (merge from main #18012)
2 parents 7e9b044 + 2f09461 commit 957172d

File tree

3 files changed

+5
-2
lines changed

3 files changed

+5
-2
lines changed

ydb/core/blobstorage/vdisk/skeleton/blobstorage_skeleton.cpp

+3-2
Original file line numberDiff line numberDiff line change
@@ -99,6 +99,7 @@ namespace NKikimr {
9999
}
100100
ctx.Send(*SkeletonFrontIDPtr, ev.release());
101101
// send VDisk's metric to NodeWarden
102+
const bool enableThrottlingReport = AppData()->FeatureFlags.GetEnableThrottlingReport();
102103
ctx.Send(NodeWardenServiceId,
103104
new TEvBlobStorage::TEvControllerUpdateDiskStatus(
104105
SelfVDiskId,
@@ -109,8 +110,8 @@ namespace NKikimr {
109110
state,
110111
replicated,
111112
outOfSpaceFlags,
112-
OverloadHandler ? OverloadHandler->IsThrottling() : false,
113-
OverloadHandler ? OverloadHandler->GetThrottlingRate() : 0));
113+
enableThrottlingReport ? std::make_optional(OverloadHandler ? OverloadHandler->IsThrottling() : false) : std::nullopt,
114+
enableThrottlingReport ? std::make_optional(OverloadHandler ? OverloadHandler->GetThrottlingRate() : 0) : std::nullopt));
114115
// repeat later
115116
ctx.Schedule(Config->WhiteboardUpdateInterval, new TEvTimeToUpdateWhiteboard());
116117
}

ydb/core/mind/bscontroller/impl.h

+1
Original file line numberDiff line numberDiff line change
@@ -284,6 +284,7 @@ class TBlobStorageController : public TActor<TBlobStorageController>, public TTa
284284
const ui64 allocatedSizeBefore = Metrics.GetAllocatedSize();
285285
const ui32 prevStatusFlags = Metrics.GetStatusFlags();
286286
Metrics.MergeFrom(vDiskMetrics);
287+
Metrics.DiscardUnknownFields();
287288
MetricsDirty = true;
288289
UpdateVDiskMetrics();
289290
*allocatedSizeIncrementPtr = Metrics.GetAllocatedSize() - allocatedSizeBefore;

ydb/core/protos/feature_flags.proto

+1
Original file line numberDiff line numberDiff line change
@@ -199,4 +199,5 @@ message TFeatureFlags {
199199
optional bool EnableChangefeedsExport = 174 [default = false];
200200
optional bool SwitchToConfigV2 = 179 [default = false];
201201
optional bool SwitchToConfigV1 = 180 [default = false];
202+
optional bool EnableThrottlingReport = 184 [default = false];
202203
}

0 commit comments

Comments
 (0)