-
Notifications
You must be signed in to change notification settings - Fork 56
PR conventions
Karelian Pie edited this page Mar 18, 2022
·
2 revisions
- Commit formats should follow Conventional Commits
- Commits should fix one issue at a time
- All comments should be resolved by the person who originally created the comment
- All comments should be resolved before merging
- Comment on your own PR where the code needs some clarification
- Any comments with feedback should be responded to by the author with a comment including the commit hash where the feedback has been resolved, or a reason with why it will not be addressed
- PRs require one approving review by a contributor with write access before it can be merged