Skip to content

Commit 69a1ec0

Browse files
feat!: drop Node 18 support (#137)
* feat!: drop Node 18 support * Automated linting/prettier update * Update snapshots * Update snapshots --------- Co-authored-by: github-actions <41898282+github-actions[bot]@users.noreply.github.com>
1 parent 80f7728 commit 69a1ec0

8 files changed

Lines changed: 8 additions & 8 deletions

File tree

.github/workflows/build.yml

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -16,7 +16,7 @@ jobs:
1616
working-directory: "./packages/${{ inputs.package }}"
1717
strategy:
1818
matrix:
19-
node-version: [18.x, 20.x, 22.x]
19+
node-version: [20.x, 22.x, 24.x]
2020
steps:
2121
- name: "Checkout"
2222
uses: actions/checkout@v4.1.6

.github/workflows/snapshots.yml

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -14,7 +14,7 @@ jobs:
1414
strategy:
1515
matrix:
1616
# TODO: Add 22.x - removed since it caused infinite screenshot loops
17-
node-version: [18.x, 20.x]
17+
node-version: [20.x]
1818
steps:
1919
- uses: actions/checkout@v4.1.6
2020
with:

.github/workflows/test-matrix.yml

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -10,7 +10,7 @@ jobs:
1010
strategy:
1111
fail-fast: false # Continue other combos even if one fails
1212
matrix:
13-
node: [18, 20, 22, 24]
13+
node: [20, 22, 24]
1414
react: ["18.2.0"] # TODO: Add "19.2.1" when ready
1515

1616
steps:

.github/workflows/unit_test.yml

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -16,7 +16,7 @@ jobs:
1616
working-directory: ./packages/${{ inputs.package }}
1717
strategy:
1818
matrix:
19-
node-version: [18.x, 20.x, 22.x]
19+
node-version: [20.x, 22.x, 24.x]
2020
steps:
2121
- name: "Checkout"
2222
uses: actions/checkout@v4.1.6

.github/workflows/wcag_test.yml

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -7,7 +7,7 @@ jobs:
77
runs-on: ubuntu-latest
88
strategy:
99
matrix:
10-
node-version: [18.x, 20.x, 22.x]
10+
node-version: [20.x, 22.x, 24.x]
1111
steps:
1212
- uses: actions/checkout@v4.1.6
1313
- uses: actions/setup-node@v4.0.2

packages/pages-components/package.json

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -31,7 +31,7 @@
3131
},
3232
"types": "dist/index.d.ts",
3333
"engines": {
34-
"node": "^18 || ^20 || ^22 || ^24"
34+
"node": "^20 || ^22 || ^24"
3535
},
3636
"scripts": {
3737
"dev": "pnpm run storybook",

test-sites/pages-components-starter/package.json

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -13,7 +13,7 @@
1313
"test": "playwright test"
1414
},
1515
"engines": {
16-
"node": "^18 || ^20.2.0 || ^22 || ^24"
16+
"node": "^20.2.0 || ^22 || ^24"
1717
},
1818
"dependencies": {
1919
"@yext/pages-components": "workspace:*",

test-sites/pages-components-starter/scripts/test-matrix-local.sh

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -9,7 +9,7 @@ if ! command -v nvm >/dev/null 2>&1; then
99
exit 1
1010
fi
1111

12-
NODE_VERSIONS=("18" "20" "22" "24")
12+
NODE_VERSIONS=("20" "22" "24")
1313
REACT_VERSIONS=("18.2.0") # TODO: Add "19.2.1"
1414

1515
INITIAL_NODE_VERSION=$(node -v)

0 commit comments

Comments
 (0)