matrix action updates and code rabbit nits

Author: mkilpatrick

.github/workflows/test-matrix.yml

@@ -14,8 +14,19 @@ jobs:
         react: ["17.0.2", "18.2.0"] # TODO: Add "19.2.1" when ready
 
     steps:
+      - name: "Checkout"
+        uses: actions/checkout@v4.1.6
+
+      - name: Use Node.js ${{ matrix.node}}
+        uses: actions/setup-node@v4.0.2
+        with:
+          node-version: ${{ matrix.node }}
+
       - name: Install pnpm
         uses: pnpm/action-setup@v4.0.0
+
+      - name: Install dependencies
+        run: pnpm install --frozen-lockfile
       - name: Pack library
         id: pack
         run: |

test-sites/pages-components-starter/config.yaml

@@ -1,10 +1,10 @@
 buildConfiguration:
-  buildCommand: npm run build
+  buildCommand: pnpm run build
   installDependenciesStep:
-    command: npm install
+    command: pnpm install
     requiredFiles:
       - package.json
-      - package-lock.json
+      - pnpm-lock.json
       - .npmrc
 livePreviewConfiguration:
   setupCommand: ":"

test-sites/pages-components-starter/localData/location-stream-aaa__en__0c50902dfc99e2dbf48b17fc9e98bee3.json

@@ -152,6 +152,7 @@
     },
     "title": "My title"
   },
+  "description": "Turtlehead Tacos in Chelsea, NYC serves fresh, made-to-order tacos with a variety of fillings and toppings in a vibrant atmosphere.",
   "hours": {
     "friday": {
       "openIntervals": [
@@ -248,4 +249,4 @@
   "siteInternalHostName": "",
   "slug": "location6-chelsea",
   "uid": 97807063
-}
+}

test-sites/pages-components-starter/package.json

@@ -28,6 +28,6 @@
     "@vitejs/plugin-react": "^4.3.3",
     "@yext/pages": "^1.2.7",
     "typescript": "^5.3.3",
-    "vite": "^5.4.10"
+    "vite": "^5.4.19"
   }
-}
+}

test-sites/pages-components-starter/playwright.config.ts

@@ -10,7 +10,6 @@ export default defineConfig({
   // Fail the build on CI if you accidentally left test.only in the source code.
   forbidOnly: !!process.env.CI,
 
-  // Retry on CI only.
   retries: 0,
 
   // Opt out of parallel tests on CI.

test-sites/pages-components-starter/scripts/test-matrix-local.sh

@@ -4,6 +4,11 @@ set -euo pipefail
 export NVM_DIR="$HOME/.nvm"
 [ -s "$NVM_DIR/nvm.sh" ] && \. "$NVM_DIR/nvm.sh"
 
+if ! command -v nvm >/dev/null 2>&1; then
+  echo "❌ Error: nvm is not available. Please install nvm first."
+  exit 1
+fi
+
 NODE_VERSIONS=("18" "20" "22" "24")
 REACT_VERSIONS=("17.0.2" "18.2.0") # TODO: Add "19.2.1"
 

test-sites/pages-components-starter/src/templates/location.tsx

@@ -24,6 +24,7 @@ export const config: TemplateConfig = {
       "meta",
       "name",
       "address",
+      "description",
       "slug",
       "hours",
       "photoGallery",
@@ -84,7 +85,7 @@ const Location: Template<TemplateRenderProps> = ({
       </div>
       <div>
         LRT via HTML:{" "}
-        {c_subfieldRTFTest.rtf.html && (
+        {c_subfieldRTFTest?.rtf?.html && (
           <div
             dangerouslySetInnerHTML={{ __html: c_subfieldRTFTest.rtf.html }}
           ></div>