Skip to content

Conversation

@yhirose
Copy link
Owner

@yhirose yhirose commented Nov 27, 2025

This PR is trying to implement #2269. It requires C++20 compiler or later which supports C++ coroutines.

@yhirose
Copy link
Owner Author

yhirose commented Nov 27, 2025

@ngxson the only thing of this new stream API is that it requires C++20 which supports C++ coroutines.

Here is README.

@yhirose yhirose force-pushed the generator branch 5 times, most recently from 414be44 to a7cfdd3 Compare December 2, 2025 01:21
@yhirose yhirose changed the title New Stream API for C++20 New Stream API Support Dec 2, 2025
@yhirose yhirose force-pushed the generator branch 3 times, most recently from 16381ea to bc058ea Compare December 2, 2025 02:07
@yhirose yhirose merged commit 8bba34e into master Dec 2, 2025
16 of 17 checks passed
@yhirose
Copy link
Owner Author

yhirose commented Dec 2, 2025

@ngxson I discarded my first implementation for C++20, then implemented the stream API which works with C++11 according to your request at #2269.

@ngxson
Copy link

ngxson commented Dec 2, 2025

Thanks, indeed C++11 or 17 is better, but not necessarily as we already moved cpp-httplib to a dedicated unit in llama.cpp. We have some other vendors compiled with C++17 too, while the main project still uses 11, so it's probably fine even if internally you want to use C++20 features

@ngxson
Copy link

ngxson commented Dec 2, 2025

Just read through the documentation, this is more than enough for me. Thanks again 😄

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants