refactor: Consolidate database connection enums into unified configuration. (#72)

Author: terabytesoftw

.github/workflows/build-mssql.yml

@@ -29,7 +29,7 @@ jobs:
         {
           "ACCEPT_EULA": "Y",
           "SA_PASSWORD": "YourStrong!Passw0rd",
-          "MSSQL_PID": "Developer"
+          "MSSQL_PID": "Developer",
         }
       database-health-cmd: "/opt/mssql-tools18/bin/sqlcmd -C -S localhost -U SA -P 'YourStrong!Passw0rd' -Q 'SELECT 1'"
       database-health-retries: 5

.github/workflows/build-oracle.yml

@@ -28,7 +28,7 @@ jobs:
       database-env: |
         {
           "ORACLE_DATABASE": "yiitest",
-          "ORACLE_PASSWORD": "root"
+          "ORACLE_PASSWORD": "root",
         }
       database-health-cmd: "healthcheck.sh"
       database-health-retries: 10

.github/workflows/build-pgsql.yml

@@ -29,7 +29,7 @@ jobs:
         {
           "POSTGRES_DB": "yiitest",
           "POSTGRES_USER": "root",
-          "POSTGRES_PASSWORD": "root"
+          "POSTGRES_PASSWORD": "root",
         }
       database-health-cmd: "pg_isready -U postgres"
       database-health-retries: 3

ecs.php

@@ -26,6 +26,7 @@
                 'constant_public',
                 'constant_protected',
                 'constant_private',
+                'case',
                 'property_public',
                 'property_protected',
                 'property_private',

tests/TestCase.php

@@ -40,12 +40,12 @@
 class TestCase extends \PHPUnit\Framework\TestCase
 {
     use SchemaBuilderTrait;
-    protected string $driverName = 'sqlite';
 
-    protected string|null $dsn = null;
+    /**
+     * @phpstan-var string[]
+     */
+    protected array $connection = [];
     protected string $fixtureDirectory = __DIR__ . '/support/data/';
-    protected string $password = '';
-    protected string $username = '';
 
     protected function setUp(): void
     {
@@ -341,12 +341,7 @@ protected function mockConsoleApplication(): void
                 'id' => 'testapp',
                 'basePath' => dirname(__DIR__),
                 'components' => [
-                    'db' => [
-                        'class' => Connection::class,
-                        'dsn' => $this->dsn !== null ? $this->dsn : 'sqlite::memory:',
-                        'password' => $this->password,
-                        'username' => $this->username,
-                    ],
+                    'db' => $this->connection,
                 ],
             ],
         );
@@ -361,7 +356,7 @@ protected function mockConsoleApplication(): void
      */
     protected function replaceQuotes(string $sql): string
     {
-        return match ($this->driverName) {
+        return match ($this->getDb()->driverName) {
             'mysql', 'sqlite' => str_replace(
                 ['[[', ']]'],
                 '`',

tests/mssql/CacheManagementTest.php

@@ -6,7 +6,7 @@
 
 use PHPUnit\Framework\Attributes\Group;
 use yii2\extensions\nestedsets\tests\base\AbstractCacheManagement;
-use yii2\extensions\nestedsets\tests\support\MSSQLConnection;
+use yii2\extensions\nestedsets\tests\support\DatabaseConnection;
 
 /**
  * Test suite for cache invalidation in nested sets tree behaviors using SQL Server.
@@ -34,10 +34,7 @@ final class CacheManagementTest extends AbstractCacheManagement
 {
     protected function setUp(): void
     {
-        $this->driverName = MSSQLConnection::DRIVER_NAME->value;
-        $this->dsn = MSSQLConnection::DSN->value;
-        $this->password = MSSQLConnection::PASSWORD->value;
-        $this->username = MSSQLConnection::USERNAME->value;
+        $this->connection = DatabaseConnection::MSSQL->connection();
 
         parent::setUp();
     }

tests/mssql/ExceptionHandlingTest.php

@@ -6,7 +6,7 @@
 
 use PHPUnit\Framework\Attributes\Group;
 use yii2\extensions\nestedsets\tests\base\AbstractExceptionHandling;
-use yii2\extensions\nestedsets\tests\support\MSSQLConnection;
+use yii2\extensions\nestedsets\tests\support\DatabaseConnection;
 
 /**
  * Test suite for exception handling in nested sets tree behaviors using SQL Server.
@@ -34,10 +34,7 @@ final class ExceptionHandlingTest extends AbstractExceptionHandling
 {
     protected function setUp(): void
     {
-        $this->driverName = MSSQLConnection::DRIVER_NAME->value;
-        $this->dsn = MSSQLConnection::DSN->value;
-        $this->password = MSSQLConnection::PASSWORD->value;
-        $this->username = MSSQLConnection::USERNAME->value;
+        $this->connection = DatabaseConnection::MSSQL->connection();
 
         parent::setUp();
     }

tests/mssql/ExtensibilityTest.php

@@ -6,7 +6,7 @@
 
 use PHPUnit\Framework\Attributes\Group;
 use yii2\extensions\nestedsets\tests\base\AbstractExtensibility;
-use yii2\extensions\nestedsets\tests\support\MSSQLConnection;
+use yii2\extensions\nestedsets\tests\support\DatabaseConnection;
 
 /**
  * Test suite for extensibility in nested sets tree behaviors using SQL Server.
@@ -34,10 +34,7 @@ final class ExtensibilityTest extends AbstractExtensibility
 {
     protected function setUp(): void
     {
-        $this->driverName = MSSQLConnection::DRIVER_NAME->value;
-        $this->dsn = MSSQLConnection::DSN->value;
-        $this->password = MSSQLConnection::PASSWORD->value;
-        $this->username = MSSQLConnection::USERNAME->value;
+        $this->connection = DatabaseConnection::MSSQL->connection();
 
         parent::setUp();
     }

tests/mssql/NodeAppendTest.php

@@ -6,7 +6,7 @@
 
 use PHPUnit\Framework\Attributes\Group;
 use yii2\extensions\nestedsets\tests\base\AbstractNodeAppend;
-use yii2\extensions\nestedsets\tests\support\MSSQLConnection;
+use yii2\extensions\nestedsets\tests\support\DatabaseConnection;
 
 /**
  * Test suite for node append and root promotion in nested sets tree behaviors using SQL Server.
@@ -37,10 +37,7 @@ final class NodeAppendTest extends AbstractNodeAppend
 {
     protected function setUp(): void
     {
-        $this->driverName = MSSQLConnection::DRIVER_NAME->value;
-        $this->dsn = MSSQLConnection::DSN->value;
-        $this->password = MSSQLConnection::PASSWORD->value;
-        $this->username = MSSQLConnection::USERNAME->value;
+        $this->connection = DatabaseConnection::MSSQL->connection();
 
         parent::setUp();
     }

tests/mssql/NodeDeleteTest.php

@@ -6,7 +6,7 @@
 
 use PHPUnit\Framework\Attributes\Group;
 use yii2\extensions\nestedsets\tests\base\AbstractNodeDelete;
-use yii2\extensions\nestedsets\tests\support\MSSQLConnection;
+use yii2\extensions\nestedsets\tests\support\DatabaseConnection;
 
 /**
  * Test suite for node deletion in nested sets tree behaviors using SQL Server.
@@ -38,10 +38,7 @@ final class NodeDeleteTest extends AbstractNodeDelete
 {
     protected function setUp(): void
     {
-        $this->driverName = MSSQLConnection::DRIVER_NAME->value;
-        $this->dsn = MSSQLConnection::DSN->value;
-        $this->password = MSSQLConnection::PASSWORD->value;
-        $this->username = MSSQLConnection::USERNAME->value;
+        $this->connection = DatabaseConnection::MSSQL->connection();
 
         parent::setUp();
     }