Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Best practice of building with dependencies #568

Open
legendecas opened this issue Oct 8, 2019 · 4 comments
Open

Best practice of building with dependencies #568

legendecas opened this issue Oct 8, 2019 · 4 comments
Labels
build doc

Comments

@legendecas
Copy link
Contributor

We should document the best practice of building on macOS with dbus installed with brew.

As pkg-config could find dbus related stuff: https://github.com/yodaos-project/ShadowNode/blob/master/cmake/iotjs.cmake#L405-L407

It might be much more convenient to brew install pkg-config then build.
@qile222
Copy link
Contributor

qile222 commented Oct 10, 2019

btw, it seems that dbus is useless, should we remove it to make building easier ?

@legendecas
Copy link
Contributor Author

Yes, dbus module could be disabled by default.

@legendecas legendecas changed the title Best practice of building on macOS Best practice of building with dependencies Oct 10, 2019
@legendecas
Copy link
Contributor Author

Still, building with pkg-config would be the be best practice if there are any system dependencies.

@yorkie
Copy link
Member

yorkie commented Oct 11, 2019

+1 on disable dbus by default

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
build doc
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@yorkie @qile222 @legendecas