-
Notifications
You must be signed in to change notification settings - Fork 1.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
bug: Always 0 vulns, Nuclei not work #1480
Comments
Hey @Flv-cmd! 👋 Thanks for flagging this bug! 🐛🔍 You're our superhero bug hunter! 🦸♂️🦸♀️ Before we suit up to squash this bug, could you please: 📚 Double-check our documentation: https://rengine.wiki Once again - thanks for your vigilance! 🛠️🚀 |
Could you please share the output of docker-compose logs --tail=300 after finishing a scan so we can see if there are any clues to DB issues? I've seen this before when Nuclei output changes and the data needs to be normalized again for saving in DB, or when parameters to initiate Nuclei change and the scans aren't completing successfully. |
Okay, there are different errors in different scans. In the first case, I got "Error: KeyError('template-url')" and the scan finished with 0 vulnerabilities found. In the second case, everything completed successfully, but just like in this issue: I don't even know which case logs to show. Previously, over the past month, I’ve deployed and deleted Rengine about 5 times, each time trying to set it up without errors. By strictly following the installation instructions, you will inevitably get a 100% error during scanning. Something will not work. This project needs serious improvement.
Interesting
In a cleanly built project, there should be no errors or issues. But this project didn't work with Nuclei v3.3.7, v3.3.8, or v3.3.9. |
And other scan log with "Error: KeyError('template-url')"
|
For #1476 , could you please try modifying the Nuclei configuration file? I think there was a breaking change in 3.3.6-3.3.9 that made template-url a required param, even if it's empty. This allowed Nuclei to get much further in test scans after I was able to recreate the template-url failures. For the vulnerability rendering issue #1480, I identified a missing comma on line 968 of the /vuln page that would impact the vulnerability table loading properly. Can you hit the API in your instance to verify that the vulnerability data is in fact in the database for your instance and reaching the page in the expected format? And yeah, there's definitely issues. Hopefully we can lay these both to rest and have an easy path to reviewing vulnerability results. Separately I'm working on improving the initial experience from setup to first scan to generating first report to help ease that frustration. |
Hi @Flv-cmd This is part of a combination of three errors I have identified in testing today impacting vulnerabilities tab and this is resolved in my test branch: Nuclei is seeing an error when template-url is absent from the default configuration as a more recent release of Nuclei made this a required param, so I have added an empty array for the definition, template-url: [], to the default configuration. I will put these changes together into a commit on a fresh install and make a PR to address these issues, targeting end of this weekend as I'm sick at the moment and moving slow. |
@dmchaledev After making changes to: /usr/src/app/startScan/templates/startScan/vulnerabilities.html
Also, in tasks.py, I changed:
After these changes, everything started working. I deliberately didn’t go into the technical details of my fixes because I simply followed all your suggestions. Now it works; at least, I tested two scans, and both showed vulnerabilities. Another question is why it finds so few vulns, but I think that’s more about the scan configuration itself. Hmm. Once again, I appreciate your attention to this issue, and I’m looking forward to the official fixes in the repository. |
Ooo, I love this approach for tasks.py in leiu of making the changes directly to the default yaml configuration, I'll include that as well as setting default configuration initially. Thank you for sharing your fix! |
…k for template-url variable, fixing missing comma, fixing encodedURLData typo
I've submitted a pull request addressing this issue here, using the tasks.py approach you took instead: #1488 |
I'm never getting nuclei to work. always just see stuff like this: `nuclei -j -irr -l /usr/src/scan_results/DOMAIN.com_672/urls_unfurled.txt -c 5 -retries 1 -rl 100 -timeout 5 -silent -t /root/nuclei-templates -severity info null` on any domain I scan |
Similarly for me - for some reason when I run rengine with nuclei on my VPS it shows 0 endpoints and I think due to that there are 0 vulns found. But when I run it locally - everything is ok. I'm using docker for both.
I think there is some problem with httpx execution on my VPS. When I check docker logs httpx doesn't execute. VPS:
LOCAL:
Also, when you run rengine for first time it downloads some packages in container. It has this python httpx in rengine-celery-1 container:
Maybe httpx alias in .bashrc is not working? I don't know... |
It started working! I did this:
and then go to "Tool arsenal" panel -> check updates for httpx fyi @wifiuk maybe it's the same case for you. |
Is there an existing issue for this?
Current Behavior
All scans I run always show 0 vulnerabilities. The scans, with different configurations, sometimes finish quickly in a few seconds, while other times they take a couple of minutes but still find 0 vulnerabilities. The Nuclei module is not working properly. It just doesn't see the targets, or I don't know...
Expected Behavior
Nuclei should detect vulnerabilities based on the selected templates and target configurations. The scan should return valid results instead of always showing 0 vulnerabilities.
Steps To Reproduce
1.Run Nuclei with different target configurations and templates.
2.Observe that the scan sometimes finishes in a few seconds, while other times it takes a couple of minutes.
3.Regardless of the configuration, the scan always returns 0 vulnerabilities.
4.The issue persists across multiple scans and target variations.
Environment
Anything else?
No response
The text was updated successfully, but these errors were encountered: