Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Double hyphen converted to – in link target #204

Closed
jmglov opened this issue Oct 6, 2024 · 2 comments · Fixed by #205
Closed

Double hyphen converted to – in link target #204

jmglov opened this issue Oct 6, 2024 · 2 comments · Fixed by #205

Comments

@jmglov
Copy link
Contributor

jmglov commented Oct 6, 2024

This may be related to #146.

I added this test to md_test.cljc:

(deftest link
  (is (= "<p><a href='http://github.com/some--stuff.html'>github</a></p>"
         (entry-function "[github](http://github.com/some--stuff.html)"))))

Running the tests yields:

: markdown-clj; bb test:bb
Running tests in #{"test"}
Testing markdown.md-file-test
Testing markdown.md-test

FAIL in (link) (/home/jmglov/Documents/code/clojure/markdown-clj/test/markdown/md_test.cljc:237)
expected: (= "<p><a href='http://github.com/some--stuff.html'>github</a></p>" (entry-function "[github](http://github.com/some--stuff.html)"))
  actual: (not (= "<p><a href='http://github.com/some--stuff.html'>github</a></p>" "<p><a href='http://github.com/some&ndash;stuff.html'>github</a></p>"))

Ran 85 tests containing 153 assertions.
1 failures, 0 errors.

I'll clone the repo and try to fix it. 🙂

@yogthos
Copy link
Owner

yogthos commented Oct 6, 2024

Awesome, a PR would be very welcome!

@jmglov
Copy link
Contributor Author

jmglov commented Nov 2, 2024

Opened a PR. 🙂

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants