Skip to content

Commit 359e685

Browse files
authored
Fixed using missing alias in compiler pass & add test (#167)
1 parent 4d6587d commit 359e685

File tree

2 files changed

+10
-1
lines changed

2 files changed

+10
-1
lines changed

src/batch-symfony-framework/src/DependencyInjection/CompilerPass/ConfigureTemplatingPass.php

+4
Original file line numberDiff line numberDiff line change
@@ -17,6 +17,10 @@ final class ConfigureTemplatingPass implements CompilerPassInterface
1717
{
1818
public function process(ContainerBuilder $container): void
1919
{
20+
if (!$container->hasAlias(TemplatingInterface::class)) {
21+
return;
22+
}
23+
2024
$templatingActualService = (string)$container->getAlias(TemplatingInterface::class);
2125

2226
try {

src/batch-symfony-framework/tests/DependencyInjection/YokaiBatchExtensionTest.php

+6-1
Original file line numberDiff line numberDiff line change
@@ -18,6 +18,7 @@
1818
use Yokai\Batch\Bridge\Symfony\Framework\UserInterface\Templating\ConfigurableTemplating;
1919
use Yokai\Batch\Bridge\Symfony\Framework\UserInterface\Templating\SonataAdminTemplating;
2020
use Yokai\Batch\Bridge\Symfony\Framework\UserInterface\Templating\TemplatingInterface;
21+
use Yokai\Batch\Bridge\Symfony\Framework\YokaiBatchBundle;
2122
use Yokai\Batch\Bridge\Symfony\Messenger\DispatchMessageJobLauncher;
2223
use Yokai\Batch\Bridge\Symfony\Uid\Factory\RandomBasedUuidJobExecutionIdGenerator;
2324
use Yokai\Batch\Bridge\Symfony\Uid\Factory\TimeBasedUuidJobExecutionIdGenerator;
@@ -423,12 +424,16 @@ private function createContainer(array $config, \Closure|null $configure = null)
423424
if ($configure !== null) {
424425
$configure($container);
425426
}
426-
$container->registerExtension(new YokaiBatchExtension());
427+
$bundle = new YokaiBatchBundle();
428+
$extension = $bundle->getContainerExtension();
429+
\assert($extension instanceof YokaiBatchExtension);
430+
$container->registerExtension($extension);
427431
$container->loadFromExtension('yokai_batch', $config);
428432

429433
$container->getCompilerPassConfig()->setOptimizationPasses([]);
430434
$container->getCompilerPassConfig()->setRemovingPasses([]);
431435
$container->getCompilerPassConfig()->setAfterRemovingPasses([]);
436+
$bundle->build($container);
432437
$container->compile();
433438

434439
return $container;

0 commit comments

Comments
 (0)