http: fix invalid unsigned arithmetic

ihsinme · azat · commit d13b7bbfcf04 · 2021-02-11T21:14:42.000+03:00
diff --git a/http.c b/http.c
@@ -565,7 +565,7 @@ evhttp_maybe_add_date_header(struct evkeyvalq *headers)
 {
 	if (evhttp_find_header(headers, "Date") == NULL) {
 		char date[50];
-		if (sizeof(date) - evutil_date_rfc1123(date, sizeof(date), NULL) > 0) {
+		if ((signed)sizeof(date) > evutil_date_rfc1123(date, sizeof(date), NULL)) {
 			evhttp_add_header(headers, "Date", date);
 		}
 	}

Original file line number	Diff line number	Diff line change
`@@ -565,7 +565,7 @@ evhttp_maybe_add_date_header(struct evkeyvalq *headers)`
`565`	`565`	`{`
`566`	`566`	`if (evhttp_find_header(headers, "Date") == NULL) {`
`567`	`567`	`char date[50];`
`568`		`- if (sizeof(date) - evutil_date_rfc1123(date, sizeof(date), NULL) > 0) {`
	`568`	`+ if ((signed)sizeof(date) > evutil_date_rfc1123(date, sizeof(date), NULL)) {`
`569`	`569`	`evhttp_add_header(headers, "Date", date);`
`570`	`570`	`}`
`571`	`571`	`}`