Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[BUG]: Mismatch between translation and string in the program (how it is possible???) #4330

Open
4 tasks done
p0k33m0n opened this issue Jan 26, 2025 · 2 comments
Open
4 tasks done
Labels
bug Something isn't working

Comments

@p0k33m0n
Copy link
Contributor

p0k33m0n commented Jan 26, 2025

Checklist

  • I made sure that there are no existing issues - open or closed - which I could contribute my information to.
  • I have read the FAQ and my problem isn't listed.
  • I have taken the time to fill in all the required details. I understand that the bug report will be dismissed otherwise.
  • This issue contains only one bug.

Affected version

25.64 Stable

Device Type

Smart TV/Box

Affected Android

Anroid TV 12

Steps to reproduce the bug

Add to Playlist option.

Actual behavior

Mismatch between translation and string in the program for the Polish language (Poland). I don't understand it, the translation is correct.

Look:
SmartTube/common/src/main/res/values-pl/strings.xml

line 44 <string name="dialog_add_to_playlist">Dodaj/Usuń z Listy odtwarzania</string>

On screen:
Image

Should be "Dodaj", and it is "Lodaj". How it is possible?

Additional information

This bug do not exits in beta_25.67. I dont get it.

@p0k33m0n p0k33m0n added the bug Something isn't working label Jan 26, 2025
@p0k33m0n p0k33m0n changed the title [BUG]: Mismatch between translation and string in the program [BUG]: Mismatch between translation and string in the program (how it is possible???) Jan 26, 2025
@edgan
Copy link

edgan commented Jan 29, 2025

git checkout 25.64
M	MediaServiceCore
M	SharedModules
M	gradlew
Previous HEAD position was a859f134b upd
HEAD is now at c62e2ba0b bump to 25.64
grep dialog_add_to_playlist common/src/main/res/values-pl/strings.xml 
  <string name="dialog_add_to_playlist">Lodaj/Usuń z Listy odtwarzania</string>

git checkout 25.67
M	MediaServiceCore
M	SharedModules
M	gradlew
Previous HEAD position was c62e2ba0b bump to 25.64
HEAD is now at a859f134b upd
grep dialog_add_to_playlist common/src/main/res/values-pl/strings.xml
  <string name="dialog_add_to_playlist">Dodaj/Usuń z Listy odtwarzania</string>
git blame common/src/main/res/values-pl/strings.xml | grep dialog_add_to_playlist
a859f134b5 (Yuriy Liskov    2025-01-26 17:21:10 +0200  44)   <string name="dialog_add_to_playlist">Dodaj/Usuń z Listy odtwarzania</string>
git show a859f134b5
commit a859f134b56c3b2e192d1670566136d3a36b842b (HEAD, tag: 25.67)
Author: Yuriy Liskov <firsthash@gmail.com>
Date:   Sun Jan 26 17:21:10 2025 +0200

    upd

diff --git a/common/src/main/res/values-pl/strings.xml b/common/src/main/res/values-pl/strings.xml
index 60ca5c955..4197f6d96 100644
--- a/common/src/main/res/values-pl/strings.xml
+++ b/common/src/main/res/values-pl/strings.xml
@@ -41,7 +41,7 @@
   <string name="update_changelog">Lista zmian</string>
   <string name="install_update">Zainstaluj aktualizację</string>
   <string name="section_is_empty">Niestety, nic tu nie ma.</string>
-  <string name="dialog_add_to_playlist">Lodaj/Usuń z Listy odtwarzania</string>
+  <string name="dialog_add_to_playlist">Dodaj/Usuń z Listy odtwarzania</string>
   <string name="msg_signed_users_only">Tylko zalogowani użytkownicy</string>
   <string name="msg_cant_load_content">Nie można załadować zawartości.\n1) Włącz historię oglądania.\n2) Sprawdź datę i godzinę na urządzeniu.\n3) Sprawdź połączenie sieciowe.\n4) Sprawdź ustawienia proxy.\n5) Spróbuj zalogować się na swoje konto.\n6) Może nic tu nie ma.</string>
   <string name="title_video_presets">Ustawienia wideo</string>

Makes perfect sense to me looking at the code in the respective tags for the two different versions. It looks like he just updated it.

Note stable vs beta are just releases. 25.64 stable and 25.64 beta are the same code. It is just two different channels with different frequency of releases. Stable is stable because in theory he only releases versions on it that are known mostly good. Where as beta is more I think this works, but we will find out. Given that 25.67 is a larger number than 25.64 and the change this is what I would expect.

I generally use beta for more bugfixes and workarounds. I have had to downgrade before through.

It is further complicated by sometimes he has motivation to rush a fix out when some Youtube change completely breaks the app.

@p0k33m0n
Copy link
Contributor Author

p0k33m0n commented Jan 30, 2025

Thank you for fully explaining the situation. By the way, I gave the author of the updated version of the translation some tips (#4335 (comment)), because he may know Polish well, but it seems to me that he does not have much experience in translating strictly IT texts.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

2 participants