Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Triggered Events don't receive arguments #143

Open
cloudratha opened this issue May 13, 2022 · 0 comments
Open

Triggered Events don't receive arguments #143

cloudratha opened this issue May 13, 2022 · 0 comments

Comments

@cloudratha
Copy link

When triggering native SW events, they do not receive the event type.

function createEvent(event, args) {
switch (event) {
case 'fetch':
return new FetchEvent('fetch', getFetchArguments(args));
case 'notificationclick':
return new NotificationEvent(args);
case 'push':
return new PushEvent(args);
case 'message':
return new MessageEvent('message', args);
default:
return new ExtendableEvent();
}
}

This is breaking pre-caching from Workbox, which specifically asserts the install event's type.

function createEvent(event, args) {
  switch (event) {
    case 'fetch':
      return new FetchEvent('fetch', getFetchArguments(args));
    case 'notificationclick':
      return new NotificationEvent(args);
    case 'push':
      return new PushEvent(args);
    case 'message':
      return new MessageEvent('message', args);
    default:
      return new ExtendableEvent(event, args);
  }
}

The above seems to produce the expected behaviour.

I attempted to fork and do a PR, however I cannot get the tests to pass on a clean install. Any advice?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant