From 43cd80a0f2ab2620878f06135eebfab26b8a501d Mon Sep 17 00:00:00 2001 From: yanngyoung Date: Mon, 13 May 2024 22:47:13 -0700 Subject: [PATCH] Move JoinFuzzer into exec/fuzzer (#9788) Summary: Currently, `JoinFuzzer` related files are mixed with test files under exec/tests. Move JoinFuzzer into exec/fuzzer to align with other Fuzzers. Pull Request resolved: https://github.com/facebookincubator/velox/pull/9788 Reviewed By: tanjialiang Differential Revision: D57314361 Pulled By: xiaoxmeng fbshipit-source-id: 1ee7889b847dfcd554dce6c9624609f928a67d4c --- velox/exec/fuzzer/CMakeLists.txt | 5 +++++ velox/exec/{tests => fuzzer}/JoinFuzzer.cpp | 2 +- velox/exec/{tests => fuzzer}/JoinFuzzer.h | 0 velox/exec/{tests => fuzzer}/JoinFuzzerRunner.h | 2 +- velox/exec/tests/CMakeLists.txt | 7 +------ velox/exec/tests/JoinFuzzerTest.cpp | 2 +- 6 files changed, 9 insertions(+), 9 deletions(-) rename velox/exec/{tests => fuzzer}/JoinFuzzer.cpp (99%) rename velox/exec/{tests => fuzzer}/JoinFuzzer.h (100%) rename velox/exec/{tests => fuzzer}/JoinFuzzerRunner.h (98%) diff --git a/velox/exec/fuzzer/CMakeLists.txt b/velox/exec/fuzzer/CMakeLists.txt index a169100a6bdf..f4f51dc455c8 100644 --- a/velox/exec/fuzzer/CMakeLists.txt +++ b/velox/exec/fuzzer/CMakeLists.txt @@ -63,3 +63,8 @@ add_library(velox_row_number_fuzzer RowNumberFuzzer.cpp) target_link_libraries( velox_row_number_fuzzer velox_fuzzer_util velox_type velox_vector_fuzzer velox_exec_test_lib velox_expression_test_utility) + +add_library(velox_join_fuzzer JoinFuzzer.cpp) + +target_link_libraries(velox_join_fuzzer velox_type velox_vector_fuzzer + velox_exec_test_lib velox_expression_test_utility) diff --git a/velox/exec/tests/JoinFuzzer.cpp b/velox/exec/fuzzer/JoinFuzzer.cpp similarity index 99% rename from velox/exec/tests/JoinFuzzer.cpp rename to velox/exec/fuzzer/JoinFuzzer.cpp index f1c534339824..3d828eaaed63 100644 --- a/velox/exec/tests/JoinFuzzer.cpp +++ b/velox/exec/fuzzer/JoinFuzzer.cpp @@ -13,7 +13,7 @@ * See the License for the specific language governing permissions and * limitations under the License. */ -#include "velox/exec/tests/JoinFuzzer.h" +#include "velox/exec/fuzzer/JoinFuzzer.h" #include #include "velox/common/file/FileSystems.h" #include "velox/connectors/hive/HiveConnector.h" diff --git a/velox/exec/tests/JoinFuzzer.h b/velox/exec/fuzzer/JoinFuzzer.h similarity index 100% rename from velox/exec/tests/JoinFuzzer.h rename to velox/exec/fuzzer/JoinFuzzer.h diff --git a/velox/exec/tests/JoinFuzzerRunner.h b/velox/exec/fuzzer/JoinFuzzerRunner.h similarity index 98% rename from velox/exec/tests/JoinFuzzerRunner.h rename to velox/exec/fuzzer/JoinFuzzerRunner.h index 524240fe58ee..a3b6532e4d2a 100644 --- a/velox/exec/tests/JoinFuzzerRunner.h +++ b/velox/exec/fuzzer/JoinFuzzerRunner.h @@ -20,7 +20,7 @@ #include "velox/common/file/FileSystems.h" #include "velox/common/memory/SharedArbitrator.h" #include "velox/exec/MemoryReclaimer.h" -#include "velox/exec/tests/JoinFuzzer.h" +#include "velox/exec/fuzzer/JoinFuzzer.h" #include "velox/serializers/PrestoSerializer.h" /// Join FuzzerRunner leverages JoinFuzzer and VectorFuzzer to diff --git a/velox/exec/tests/CMakeLists.txt b/velox/exec/tests/CMakeLists.txt index 6b1f0f86b7da..e4f37be2c5f1 100644 --- a/velox/exec/tests/CMakeLists.txt +++ b/velox/exec/tests/CMakeLists.txt @@ -201,18 +201,13 @@ target_link_libraries( velox_tpch_connector velox_memory) -# Join Fuzzer. -add_library(velox_join_fuzzer JoinFuzzer.cpp) - -target_link_libraries(velox_join_fuzzer velox_type velox_vector_fuzzer - velox_exec_test_lib velox_expression_test_utility) - # RowNumber Fuzzer. add_executable(velox_row_number_fuzzer_test RowNumberFuzzerTest.cpp) target_link_libraries(velox_row_number_fuzzer_test velox_row_number_fuzzer gtest gtest_main) +# Join Fuzzer. add_executable(velox_join_fuzzer_test JoinFuzzerTest.cpp) target_link_libraries(velox_join_fuzzer_test velox_join_fuzzer gtest gtest_main) diff --git a/velox/exec/tests/JoinFuzzerTest.cpp b/velox/exec/tests/JoinFuzzerTest.cpp index 6b51c2a858c8..32f8beae42ee 100644 --- a/velox/exec/tests/JoinFuzzerTest.cpp +++ b/velox/exec/tests/JoinFuzzerTest.cpp @@ -19,7 +19,7 @@ #include #include -#include "velox/exec/tests/JoinFuzzerRunner.h" +#include "velox/exec/fuzzer/JoinFuzzerRunner.h" DEFINE_int64( seed,