From 4ad5a8a65d6fcbae401a52803447e6530454aad8 Mon Sep 17 00:00:00 2001 From: Kevin Wilfong Date: Thu, 16 Jan 2025 11:59:07 -0800 Subject: [PATCH] test: Upgrade the version of Presto we compare fuzzers in CI against to 0.290 (#12096) Summary: Pull Request resolved: https://github.com/facebookincubator/velox/pull/12096 We currently run Aggregation, Window, and Writer fuzzers comparing against Presto in CI jobs. They run Presto at version 0.288. There are known compatibility issues with this older version, e.g. set_agg and set_union are disabled in AggregationFuzzer because of this. 0.290 appears to be the latest release from Presto and addresses these (we should be able to enable set_agg and set_union after this). I ran the Aggregation, Window, and Writer fuzzers against this version of Presto for an hour and didn't see issues. We also already run AggregationFuzzer against Presto trunk (or close to it) for every PR internally. Reviewed By: kgpai Differential Revision: D68280837 fbshipit-source-id: 74746306d5065d582dc822e5df3cc98e0bc441a0 --- .github/workflows/docker.yml | 2 +- docker-compose.yml | 2 +- scripts/prestojava-container.dockerfile | 2 +- 3 files changed, 3 insertions(+), 3 deletions(-) diff --git a/.github/workflows/docker.yml b/.github/workflows/docker.yml index a8e104565122..358c72fd60b2 100644 --- a/.github/workflows/docker.yml +++ b/.github/workflows/docker.yml @@ -91,7 +91,7 @@ jobs: tags: "ghcr.io/facebookincubator/velox-dev:adapters" - name: Presto Java file: "scripts/prestojava-container.dockerfile" - args: "PRESTO_VERSION=0.288" + args: "PRESTO_VERSION=0.290" tags: "ghcr.io/facebookincubator/velox-dev:presto-java" - name: Spark server file: "scripts/spark-container.dockerfile" diff --git a/docker-compose.yml b/docker-compose.yml index 6904baa543ee..6c2a27ab2d19 100644 --- a/docker-compose.yml +++ b/docker-compose.yml @@ -90,7 +90,7 @@ services: image: ghcr.io/facebookincubator/velox-dev:presto-java build: args: - - PRESTO_VERSION=0.288 + - PRESTO_VERSION=0.290 context: . dockerfile: scripts/prestojava-container.dockerfile environment: diff --git a/scripts/prestojava-container.dockerfile b/scripts/prestojava-container.dockerfile index 7ef27c6f68a5..8e421e29e7f7 100644 --- a/scripts/prestojava-container.dockerfile +++ b/scripts/prestojava-container.dockerfile @@ -15,7 +15,7 @@ # FROM ghcr.io/facebookincubator/velox-dev:centos9 -ARG PRESTO_VERSION=0.288 +ARG PRESTO_VERSION=0.290 ADD scripts /velox/scripts/ RUN wget https://repo1.maven.org/maven2/com/facebook/presto/presto-server/${PRESTO_VERSION}/presto-server-${PRESTO_VERSION}.tar.gz