From 9fde0a2c4bc392d71524e43472604a506b02b6b9 Mon Sep 17 00:00:00 2001 From: Zac Wen Date: Sun, 5 May 2024 23:11:29 -0700 Subject: [PATCH] Pass an executor to SsdFile (#9710) Summary: Checkpoint relies on the executor to schedule a potentially long fsync of cache file on another thread. Currently it is not set. Pull Request resolved: https://github.com/facebookincubator/velox/pull/9710 Reviewed By: xiaoxmeng Differential Revision: D56965318 Pulled By: zacw7 fbshipit-source-id: 13f50f08c840e7a92fcede3ecb2f4ce63caa044e --- velox/common/caching/SsdCache.cpp | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/velox/common/caching/SsdCache.cpp b/velox/common/caching/SsdCache.cpp index 5b11fe89eebf..d48eea9ae254 100644 --- a/velox/common/caching/SsdCache.cpp +++ b/velox/common/caching/SsdCache.cpp @@ -60,7 +60,8 @@ SsdCache::SsdCache( i, fileMaxRegions, checkpointIntervalBytes / numShards, - disableFileCow)); + disableFileCow, + executor_)); } }