Skip to content

Commit 680142f

Browse files
Missing mandatory keyword argument (#2465)
The keyword argument `shape` is mandatory.
1 parent 473308a commit 680142f

File tree

1 file changed

+6
-6
lines changed

1 file changed

+6
-6
lines changed

src/zarr/core/group.py

+6-6
Original file line numberDiff line numberDiff line change
@@ -967,7 +967,7 @@ async def create_array(
967967

968968
@deprecated("Use AsyncGroup.create_array instead.")
969969
async def create_dataset(
970-
self, name: str, **kwargs: Any
970+
self, name: str, *, shape: ShapeLike, **kwargs: Any
971971
) -> AsyncArray[ArrayV2Metadata] | AsyncArray[ArrayV3Metadata]:
972972
"""Create an array.
973973
@@ -988,7 +988,7 @@ async def create_dataset(
988988
.. deprecated:: 3.0.0
989989
The h5py compatibility methods will be removed in 3.1.0. Use `AsyncGroup.create_array` instead.
990990
"""
991-
return await self.create_array(name, **kwargs)
991+
return await self.create_array(name, shape=shape, **kwargs)
992992

993993
@deprecated("Use AsyncGroup.require_array instead.")
994994
async def require_dataset(
@@ -1666,7 +1666,7 @@ def create_dataset(self, name: str, **kwargs: Any) -> Array:
16661666
return Array(self._sync(self._async_group.create_dataset(name, **kwargs)))
16671667

16681668
@deprecated("Use Group.require_array instead.")
1669-
def require_dataset(self, name: str, **kwargs: Any) -> Array:
1669+
def require_dataset(self, name: str, *, shape: ShapeLike, **kwargs: Any) -> Array:
16701670
"""Obtain an array, creating if it doesn't exist.
16711671
16721672
Arrays are known as "datasets" in HDF5 terminology. For compatibility
@@ -1688,9 +1688,9 @@ def require_dataset(self, name: str, **kwargs: Any) -> Array:
16881688
.. deprecated:: 3.0.0
16891689
The h5py compatibility methods will be removed in 3.1.0. Use `Group.require_array` instead.
16901690
"""
1691-
return Array(self._sync(self._async_group.require_array(name, **kwargs)))
1691+
return Array(self._sync(self._async_group.require_array(name, shape=shape, **kwargs)))
16921692

1693-
def require_array(self, name: str, **kwargs: Any) -> Array:
1693+
def require_array(self, name: str, *, shape: ShapeLike, **kwargs: Any) -> Array:
16941694
"""Obtain an array, creating if it doesn't exist.
16951695
16961696
@@ -1707,7 +1707,7 @@ def require_array(self, name: str, **kwargs: Any) -> Array:
17071707
-------
17081708
a : Array
17091709
"""
1710-
return Array(self._sync(self._async_group.require_array(name, **kwargs)))
1710+
return Array(self._sync(self._async_group.require_array(name, shape=shape, **kwargs)))
17111711

17121712
@_deprecate_positional_args
17131713
def empty(self, *, name: str, shape: ChunkCoords, **kwargs: Any) -> Array:

0 commit comments

Comments
 (0)