Tests for pathlib use

Author: clbarnes

zarr/tests/conftest.py

@@ -0,0 +1,8 @@
+from pathlib import Path
+
+import pytest
+
+
+@pytest.fixture(params=[str, Path])
+def path_type(request):
+    return request.param

zarr/tests/test_convenience.py

@@ -27,10 +27,11 @@
                           atexit_rmtree, getsize)
 
 
-def test_open_array():
+def test_open_array(path_type):
 
     store = tempfile.mkdtemp()
     atexit.register(atexit_rmtree, store)
+    store = path_type(store)
 
     # open array, create if doesn't exist
     z = open(store, mode='a', shape=100)
@@ -53,10 +54,11 @@ def test_open_array():
         open('doesnotexist', mode='r')
 
 
-def test_open_group():
+def test_open_group(path_type):
 
     store = tempfile.mkdtemp()
     atexit.register(atexit_rmtree, store)
+    store = path_type(store)
 
     # open group, create if doesn't exist
     g = open(store, mode='a')

zarr/tests/test_storage.py

@@ -2,6 +2,7 @@
 import atexit
 import json
 import os
+from pathlib import Path
 import sys
 import pickle
 import shutil
@@ -836,6 +837,11 @@ def test_filesystem_path(self):
             with pytest.raises(ValueError):
                 DirectoryStore(f.name)
 
+    def test_init_pathlib(self):
+        path = tempfile.mkdtemp()
+        atexit.register(atexit_rmtree, path)
+        DirectoryStore(Path(path))
+
     def test_pickle_ext(self):
         store = self.create_store()
         store2 = pickle.loads(pickle.dumps(store))