Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

botocore should be listed in test requirements #2731

Open
QuLogic opened this issue Jan 19, 2025 · 2 comments
Open

botocore should be listed in test requirements #2731

QuLogic opened this issue Jan 19, 2025 · 2 comments
Labels
bug Potential issues with the zarr-python library

Comments

@QuLogic
Copy link
Contributor

QuLogic commented Jan 19, 2025

Zarr version

3.0.1

Numcodecs version

0.14.0

Python Version

3.13.1

Operating System

Fedora rawhide

Installation

source

Description

It is always imported in tests, so should be part of the test extra in pyproject.toml.

from botocore.session import Session

If instead you expect it to be required transitively through some other dependency, then it should be imported below the importorskip lines.

fsspec = pytest.importorskip("fsspec")
s3fs = pytest.importorskip("s3fs")
requests = pytest.importorskip("requests")
moto_server = pytest.importorskip("moto.moto_server.threaded_moto_server")
moto = pytest.importorskip("moto")

Steps to reproduce

pip install zarr[test]
pytest

Additional output

No response

@QuLogic QuLogic added the bug Potential issues with the zarr-python library label Jan 19, 2025
@QuLogic
Copy link
Contributor Author

QuLogic commented Jan 19, 2025

Perhaps also aiohttp or fsspec[http] for test_make_store_path_fsspec .

@d-v-b
Copy link
Contributor

d-v-b commented Jan 19, 2025

thanks for the report. I think we need to refactor the how we test the fsspec-dependent stuff entirely, and that effort should include the changes you propose here.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Potential issues with the zarr-python library
Projects
None yet
Development

No branches or pull requests

2 participants