-
-
Notifications
You must be signed in to change notification settings - Fork 321
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
DOC: Top-level Store removal not in v3 migration guide #2733
Comments
thanks for the report, and sorry for the inconvenience caused here. we should definitely update the guide as you suggest |
I’d like to help document the store import changes for #2733. If this is not assigned to anyone. Plan:
Is this the right approach? |
@OPMTerra that sounds great, thanks for your help! |
My PR #2883 is ready for review! Changes made:
This should help users avoid confusion like in imagecodecs#123 by clearly showing the new import paths. Let me know if any adjustments are needed! |
Describe the issue linked to the documentation
I've found that
imagecodecs
fails to build with Zarr 3 cgohlke/imagecodecs#123 due to their use ofzarr.MemoryStore
.While I linked to the migration guide, a search through it does not have any mention of
MemoryStore
. I think they should be usingzarr.storage.MemoryStore
instead, but there's no note there and I don't know if that was available in v2 or not.Suggested fix for documentation
All
zarr.*Store
removals should be mentioned in the v3 migration guide along with their replacements.The text was updated successfully, but these errors were encountered: