Revert "Use gh workflow for tests" (#41411)

Reverts #41384

The branch-protection rules work much better when there is a Job that
runs every time and can be depended on to pass, we no longer have this.

Release Notes:

- N/A

Author: probably-neb

.github/workflows/ci.yml

@@ -2,9 +2,16 @@ name: CI
 
 on:
   push:
+    branches:
+      - main
+      - "v[0-9]+.[0-9]+.x"
     tags:
       - "v*"
 
+  pull_request:
+    branches:
+      - "**"
+
 concurrency:
   # Allow only one workflow per any non-`main` branch.
   group: ${{ github.workflow }}-${{ github.ref_name }}-${{ github.ref_name == 'main' && github.sha || 'anysha' }}
@@ -266,12 +273,15 @@ jobs:
         uses: ./.github/actions/run_tests
 
       - name: Build collab
-        # we should do this on a linux x86 machinge
         run: cargo build -p collab
 
       - name: Build other binaries and features
         run: |
-          cargo build --workspace --bins --examples
+          cargo build --workspace --bins --all-features
+          cargo check -p gpui --features "macos-blade"
+          cargo check -p workspace
+          cargo build -p remote_server
+          cargo check -p gpui --examples
 
       # Since the macOS runners are stateful, so we need to remove the config file to prevent potential bug.
       - name: Clean CI config file
@@ -721,6 +731,10 @@ jobs:
       (contains(github.event.pull_request.labels.*.name, 'run-nix') ||
       needs.job_spec.outputs.run_nix == 'true')
     secrets: inherit
+    with:
+      flake-output: debug
+      # excludes the final package to only cache dependencies
+      cachix-filter: "-zed-editor-[0-9.]*-nightly"
 
   bundle-windows-x64:
     timeout-minutes: 120

.github/workflows/nix_build.yml

@@ -1,31 +1,14 @@
 # Generated from xtask::workflows::nix_build
 # Rebuild with `cargo xtask workflows`.
 name: nix_build
-env:
-  CARGO_TERM_COLOR: always
-  RUST_BACKTRACE: '1'
-  CARGO_INCREMENTAL: '0'
 on:
-  pull_request:
-    branches:
-    - '**'
-    paths:
-    - nix/**
-    - flake.*
-    - Cargo.*
-    - rust-toolchain.toml
-    - .cargo/config.toml
-  push:
-    branches:
-    - main
-    - v[0-9]+.[0-9]+.x
-    paths:
-    - nix/**
-    - flake.*
-    - Cargo.*
-    - rust-toolchain.toml
-    - .cargo/config.toml
-  workflow_call: {}
+  workflow_call:
+    inputs:
+      flake-output:
+        type: string
+        default: default
+      cachix-filter:
+        type: string
 jobs:
   build_nix_linux_x86_64:
     if: github.repository_owner == 'zed-industries'
@@ -50,9 +33,9 @@ jobs:
         name: zed
         authToken: ${{ secrets.CACHIX_AUTH_TOKEN }}
         cachixArgs: -v
-        pushFilter: -zed-editor-[0-9.]*-nightly
+        pushFilter: ${{ inputs.cachix-filter }}
     - name: nix_build::build
-      run: nix build .#debug -L --accept-flake-config
+      run: nix build .#${{ inputs.flake-output }} -L --accept-flake-config
       shell: bash -euxo pipefail {0}
     timeout-minutes: 60
     continue-on-error: true
@@ -80,9 +63,9 @@ jobs:
         name: zed
         authToken: ${{ secrets.CACHIX_AUTH_TOKEN }}
         cachixArgs: -v
-        pushFilter: -zed-editor-[0-9.]*-nightly
+        pushFilter: ${{ inputs.cachix-filter }}
     - name: nix_build::build
-      run: nix build .#debug -L --accept-flake-config
+      run: nix build .#${{ inputs.flake-output }} -L --accept-flake-config
       shell: bash -euxo pipefail {0}
     - name: nix_build::limit_store
       run: |-
@@ -92,6 +75,3 @@ jobs:
       shell: bash -euxo pipefail {0}
     timeout-minutes: 60
     continue-on-error: true
-concurrency:
-  group: ${{ github.workflow }}-${{ github.ref_name }}-${{ github.ref_name == 'main' && github.sha || 'anysha' }}
-  cancel-in-progress: true

.github/workflows/release_nightly.yml

@@ -49,9 +49,6 @@ jobs:
       uses: actions/setup-node@49933ea5288caeca8642d1e84afbd3f7d6820020
       with:
         node-version: '20'
-    - name: steps::clippy
-      run: ./script/clippy
-      shell: bash -euxo pipefail {0}
     - name: steps::cargo_install_nextest
       run: cargo install cargo-nextest --locked
       shell: bash -euxo pipefail {0}
@@ -84,9 +81,6 @@ jobs:
       uses: actions/setup-node@49933ea5288caeca8642d1e84afbd3f7d6820020
       with:
         node-version: '20'
-    - name: steps::clippy
-      run: ./script/clippy.ps1
-      shell: pwsh
     - name: steps::cargo_install_nextest
       run: cargo install cargo-nextest --locked
       shell: pwsh

.github/workflows/run_action_checks.yml

@@ -109,10 +109,10 @@ jobs:
       uses: matbour/setup-sentry-cli@3e938c54b3018bdd019973689ef984e033b0454b
       with:
         token: ${{ secrets.SENTRY_AUTH_TOKEN }}
-    - name: steps::setup_linux
+    - name: ./script/linux
       run: ./script/linux
       shell: bash -euxo pipefail {0}
-    - name: steps::install_mold
+    - name: ./script/install-mold
       run: ./script/install-mold
       shell: bash -euxo pipefail {0}
     - name: ./script/bundle-linux
@@ -143,12 +143,9 @@ jobs:
       uses: matbour/setup-sentry-cli@3e938c54b3018bdd019973689ef984e033b0454b
       with:
         token: ${{ secrets.SENTRY_AUTH_TOKEN }}
-    - name: steps::setup_linux
+    - name: ./script/linux
       run: ./script/linux
       shell: bash -euxo pipefail {0}
-    - name: steps::install_mold
-      run: ./script/install-mold
-      shell: bash -euxo pipefail {0}
     - name: ./script/bundle-linux
       run: ./script/bundle-linux
       shell: bash -euxo pipefail {0}