Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improve Gleam syntax highlighting #16874

Closed
1 task done
ghivert opened this issue Aug 26, 2024 · 1 comment
Closed
1 task done

Improve Gleam syntax highlighting #16874

ghivert opened this issue Aug 26, 2024 · 1 comment
Labels
feature [core label] gleam Gleam programming language support language An umbrella label for all programming languages syntax behaviors

Comments

@ghivert
Copy link

ghivert commented Aug 26, 2024

Check for existing issues

  • Completed

Describe the feature

Hi! I'm not sure where to talk about the subject, so I prefer open an issue. 🙂

Those days, I was trying to see if we can improve the syntax highlighting for Gleam.
Currently, in the syntax highlighting, we got all functions calls highlighted as records access when they're done in a fully qualified way.

import my_package
pub fn main() {
  my_package.function() // <-- On Zed, this is highlighted as record property, and not function.
}

What do you think to modify the Gleam syntax highlighting (i.e. highlights.scm) to highlight every functions used from records with proper functions highlighting? I tried to implement it here to figure out how it can be. (I'm absolutely not sure it's correctly implemented, I mainly wanted to prove myself it was possible.) I also joined two screenshots on how it feels directly in the editor.

I know tree sitter can not know if the field is a function or not (because we can have a constant, so calling it will result in an error), but the LSP could take care of this, and — in my opinion — having a proper function highlighting for fields called as functions will improve readability.

If applicable, add mockups / screenshots to help present your vision of the feature

Function syntax highlighted

Capture d’écran 2024-08-26 à 15 29 38

Record syntax highlighted

Capture d’écran 2024-08-26 à 15 29 46
@ghivert ghivert added admin read feature [core label] labels Aug 26, 2024
@JosephTLyons JosephTLyons added language An umbrella label for all programming languages syntax behaviors gleam Gleam programming language support and removed triage labels Aug 26, 2024
@JosephTLyons
Copy link
Collaborator

Hey @ghivert, we recently moved the zed-gleam repo to the Gleam org, so I went ahead and moved this issue over there. Had to do it manually, but here is the link:

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
feature [core label] gleam Gleam programming language support language An umbrella label for all programming languages syntax behaviors
Projects
None yet
Development

No branches or pull requests

2 participants