Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Defaulting port for addTarget command switch 'zsurl' #93

Closed
MassiAtZend opened this issue Jul 13, 2016 · 3 comments
Closed

Defaulting port for addTarget command switch 'zsurl' #93

MassiAtZend opened this issue Jul 13, 2016 · 3 comments

Comments

@MassiAtZend
Copy link

The 'addTarget' command should be able to accept also a 'zsurl' value like 'http://testing-platform' or 'https://testing-platform' , defaulting the port to 10081 or 10082 respectively.

@zvikazend
Copy link
Contributor

Not sure this is correct. Why to drop on default? If someone has the GUI on non-standard port on NAT with multiple dev servers?
10081 and 10082 should always be visible, so if they are in the ZSURL, listTargets will show you the port and you don't "accidentally" miss that and break your head why you don't get the GUI on HTTP 80 or HTTPS 443 in browser.
But - feel free to enhance if you still fell its wanted.

@MassiAtZend
Copy link
Author

If the port is given, it stays the same, but if it's not given it should default according to the schema.
Right now, if you put --zsurl='http://testing-platform' it fails on an uncaught RuntimeException. Why not try defaulting on 'http://testing-platform:10081'?

@zvikazend
Copy link
Contributor

right. I think it should respond back with a note about defaulting to 10081 or 10082, in case the user needs to alter the target. Thanks

@slaff slaff closed this as completed in ba2b682 Jul 19, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

3 participants