SQL Server ALTER TABLE adding column

[alextech]

SQL Server Ddl\AlterTable addColumn produces

 ALTER TABLE [users]
 ADD COLUMN [profile_image] INTEGER

Should be

ALTER TABLE [users]
ADD [profile_image] INTEGER

[froschdesign]

Add the moment there is no decorator to manipulate the ALTER TABLE syntax from the SQL Server.

[alextech]

Yes, I will add it the same way I added decorator for PostgreSQL to fix index bugs. Just felt sad that a platform which is in list of supported ones gives this many syntax errors on basic commands so adding this to my todo list after I finish fixing sequence bugs.

[froschdesign]

@alextech

Just felt sad that a platform which is in list of supported ones...

Where?

[alextech]

@froschdesign
https://docs.zendframework.com/zend-db/adapter/

The list of officially supported drivers:
IbmDb2: The ext/ibm_db2 deriver
Mysqli: The ext/mysqli driver
Oci8: The ext/oci8 driver
Pgsql: The ext/pgsql driver
Sqlsrv: The ext/sqlsrv driver (from Microsoft)
Pdo_Mysql: MySQL via the PDO extension
Pdo_Sqlite: SQLite via the PDO extension
Pdo_Pgsql: PostgreSQL via the PDO extension

[froschdesign]

@alextech
Adapter not DDL Abstraction!

The following platforms have platform specializations for DDL:

• MySQL
• All databases compatible with ANSI SQL92

https://docs.zendframework.com/zend-db/sql-ddl/

[alextech]

@froschdesign
Support for driver does not imply support across the whole package? That is unexpected, but OK, point taken. In that case, last 3 issues, and probably many more undiscovered ones, do not need fixing that much, can be closed, since according to that other link its not officially supported and effort taken to add full support may not be worth it, unless you disagree.

[froschdesign]

The priority is not very high for the DDL Abstraction. (imo)

[alextech]

That is fine.

[ezimuel]

@froschdesign we are already supporting DDL for specific platform like SQL Server, see here.
The documentation should be updated https://docs.zendframework.com/zend-db/sql-ddl/.
That said, I would love to see a PR from @alextech with a decorator for AlterTable on SqlServer.

[alextech]

@ezimuel I am on it! Thank you for motivation. Even though I was mostly focused on sequences, not being able to set up migrations to support testing of higher-level featured due to these API limitations was a significant annoyance so this distraction will help.

Question about workflow. You assigned it to yourself so does that mean you are working on it or you are willing to review what I will submit? I do not want to cause extra difficulties for you submitting conflicting PRs.

[ezimuel]

@alextech I assigned to myself so I remember to manage it. Please, work on the PR and I'll review it, and thanks in advance for your contribution!

[froschdesign]

@ezimuel

we are already supporting DDL for specific platform like SQL Server

Right, but not for the ALTER TABLE syntax. 😉