Skip to content
This repository was archived by the owner on Jan 30, 2020. It is now read-only.

'Value is required' message should be localizable #28

Closed
tflin opened this issue Aug 21, 2015 · 3 comments
Closed

'Value is required' message should be localizable #28

tflin opened this issue Aug 21, 2015 · 3 comments
Labels
bug
Milestone
2.4.8

Comments

@tflin
Copy link

tflin commented Aug 21, 2015

We had the issue that 'Value is required' message can not be localized to Chinese as it is hardcoded in the framework code. The custom-message NotEmpty validator cannot override this error message in our case. Please help to make the hardcoded message localizable.
@Maks3w Maks3w added the bug label Aug 21, 2015
@Maks3w Maks3w added this to the 2.4.8 milestone Aug 21, 2015
@Maks3w Maks3w mentioned this issue Aug 27, 2015
Closed
@Maks3w
Copy link
Member

Maks3w commented Sep 1, 2015

@weierophinney said: Does this resolve the issue with the NotEmpty messages that have occurred since 2.4? It seems like we should set it in the same format, using the same key, in order to retain the previous behavior?

From #24

This is an idea for localize the string

@larsnystrom larsnystrom mentioned this issue Sep 1, 2015
Closed
@Maks3w Maks3w mentioned this issue Sep 3, 2015
Closed
@weierophinney weierophinney mentioned this issue Sep 3, 2015
Merged
@weierophinney
Copy link
Member

Fixed with #61

stefanotorresi added a commit to stefanotorresi/zend-inputfilter that referenced this issue Sep 21, 2015
@stefanotorresi
add failing test for zendframework#28
61d5ddc
stefanotorresi added a commit to stefanotorresi/zend-inputfilter that referenced this issue Sep 21, 2015
@stefanotorresi
fix zendframework#28 - notempty validator i18n
5cd2801
@stefanotorresi stefanotorresi mentioned this issue Sep 21, 2015
Merged
@stefanotorresi
Copy link
Contributor

@weierophinney i'm afraid it actually isn't, see #67

@larsnystrom larsnystrom mentioned this issue Oct 7, 2015
Merged
weierophinney added a commit that referenced this issue Apr 7, 2016
@weierophinney
Merge pull request #67 from stefanotorresi/fix-input-not-empty-messag…
aab0982 
…e-i18n

Fix #28 - NotEmpty validation message cannot be localized
weierophinney added a commit that referenced this issue Apr 7, 2016
@weierophinney
Merge branch 'hotfix/67'
6dbe9d6 
Close #67
Fixes #28
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees
No one assigned
Labels
bug
Projects
None yet
Milestone
2.4.8
Development

No branches or pull requests
4 participants
@weierophinney @Maks3w @stefanotorresi @tflin